You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/13 02:17:07 UTC
[GitHub] [flink] XuQianJin-Stars opened a new pull request #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
XuQianJin-Stars opened a new pull request #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395
## What is the purpose of the change
Support IS JSON predication for Table API in blink planner
`IS_JSON_VALUE`
`IS_JSON_OBJECT`
`IS_JSON_ARRAY`
`IS_JSON_SCALAR`
`IS_NOT_JSON_VALUE`
`IS_NOT_JSON_OBJECT`
`IS_NOT_JSON_ARRAY`
`IS_NOT_JSON_SCALAR`
## Brief change log
*(for example:)*
- Introduce IS JSON predicates to `BuiltInFunctionDefinitions.java` and `BaseExpressions.java `
- Implement supporting generation logic, including a new `jsonExpressions.scala`
- Add corresponding test cases
## Verifying this change
*(Please pick either of the following options)*
This change added tests in `JsonFunctionsTest.scala`
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153112115",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43c018ea5e3be93ed538fe32165dda04138fbcf3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153112115) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598515852
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 43c018ea5e3be93ed538fe32165dda04138fbcf3 (Fri Mar 13 02:19:12 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16501).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153112115",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153116402",
"triggerID" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"triggerType" : "PUSH"
}, {
"hash" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6260",
"triggerID" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43c018ea5e3be93ed538fe32165dda04138fbcf3 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/153112115) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257)
* 5a7f34903762fc0e644b0a0b59146b76c701d52c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153116402) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6260)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43c018ea5e3be93ed538fe32165dda04138fbcf3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153112115",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153116402",
"triggerID" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"triggerType" : "PUSH"
}, {
"hash" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6260",
"triggerID" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a7f34903762fc0e644b0a0b59146b76c701d52c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153116402) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6260)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153112115",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43c018ea5e3be93ed538fe32165dda04138fbcf3 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/153112115) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153112115",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153116402",
"triggerID" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"triggerType" : "PUSH"
}, {
"hash" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6260",
"triggerID" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a7f34903762fc0e644b0a0b59146b76c701d52c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153116402) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6260)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153112115",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a7f34903762fc0e644b0a0b59146b76c701d52c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43c018ea5e3be93ed538fe32165dda04138fbcf3 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/153112115) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257)
* 5a7f34903762fc0e644b0a0b59146b76c701d52c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11395: [FLINK-16501][sql] Support IS JSON predication for Table API in blink…
URL: https://github.com/apache/flink/pull/11395#issuecomment-598517763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
}, {
"hash" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153112115",
"triggerID" : "43c018ea5e3be93ed538fe32165dda04138fbcf3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43c018ea5e3be93ed538fe32165dda04138fbcf3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153112115) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6257)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services