[GitHub] [superset] mistercrunch commented on pull request #13223: chore: add logs to db test connection and post failures

[GitBox <gi...@apache.org>]

mistercrunch commented on pull request #13223:
URL: https://github.com/apache/superset/pull/13223#issuecomment-784666308


   Can we add two analytics events on top of the statsd events here too!? 
   
   I'd love to throw in the database `engine` details in these events. Currently we have the API call `test_connection` logged through the decorator, but I'd add `test_connection_success` and `test_connection_failed` on top, with the engine detail.
   
   Check out the `event_logger.log_context` context_generator, here's an example https://github.com/apache/superset/blob/master/superset/connectors/sqla/models.py#L1492


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org