Re: [PR] fix bug with `to_timestamp` and `InitCap` logical serialization, add roundtrip test between expression and proto, [arrow-datafusion]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #8868:
URL: https://github.com/apache/arrow-datafusion/pull/8868#discussion_r1453593177


##########
datafusion/proto/tests/cases/serialize.rs:
##########
@@ -243,3 +243,41 @@ fn context_with_udf() -> SessionContext {
 
     ctx
 }
+
+#[test]
+fn test_expression_serialization_roundtrip() {
+    use datafusion_common::ScalarValue;
+    use datafusion_expr::expr::ScalarFunction;
+    use datafusion_expr::BuiltinScalarFunction;
+    use datafusion_proto::logical_plan::from_proto::parse_expr;
+    use datafusion_proto::protobuf::LogicalExprNode;
+    use strum::IntoEnumIterator;
+
+    let ctx = SessionContext::new();
+    let lit = Expr::Literal(ScalarValue::Utf8(None));
+    for builtin_fun in BuiltinScalarFunction::iter() {
+        println!("Checking function: {}", builtin_fun.name());

Review Comment:
   nit: we should probably remove this debug logging?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org