aderm opened a new pull request #4151: [test/plugin] immigrate test activemq scenario. URL: https://github.com/apache/skywalking/pull/4151 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related issues #3583 ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services
codecov-io edited a comment on issue #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569657596
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=h1) Report
> Merging [#4151](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
+ Coverage 27.13% 27.18% +0.04%
==========================================
Files 1145 1145
Lines 25105 25105
Branches 3631 3631
==========================================
+ Hits 6812 6824 +12
+ Misses 17690 17675 -15
- Partials 603 606 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4151/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=footer). Last update [1ee14fb...a0d76c1](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
codecov-io edited a comment on issue #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569657596
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=h1) Report
> Merging [#4151](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
+ Coverage 27.13% 27.18% +0.04%
==========================================
Files 1145 1145
Lines 25105 25105
Branches 3631 3631
==========================================
+ Hits 6812 6824 +12
+ Misses 17690 17675 -15
- Partials 603 606 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4151/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=footer). Last update [1ee14fb...8b06f1c](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
dmsolr commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r361969343
##########
File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {activemq-scenario: nq 0}
+ instances:
+ - {activemq-scenario: nq 0}
+ operationNames:
+ - activemq-scenario: [ActiveMQ/Queue/test/Producer, ActiveMQ/Queue/test/Consumer, /activemq-scenario/case/activemq]
+ heartbeat: []
+segmentItems:
+- applicationCode: activemq-scenario
+ segmentSize: ge 2
+ segments:
+ - segmentId: /activemq-scenario/case/activemq
Review comment:
The `segmentId` is generated by SkyWalking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
wu-sheng commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r362020674
##########
File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {activemq-scenario: nq 0}
+ instances:
+ - {activemq-scenario: nq 0}
+ operationNames:
+ - activemq-scenario: [ActiveMQ/Queue/test/Producer, ActiveMQ/Queue/test/Consumer, /activemq-scenario/case/activemq]
+ heartbeat: []
+segmentItems:
+- applicationCode: activemq-scenario
+ segmentSize: ge 2
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /activemq-scenario/case/activemq
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 1
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ tags:
+ - {key: url, value: 'http://localhost:8080/activemq-scenario/case/activemq'}
+ - {key: http.method, value: GET}
+ - segmentId: not null
+ spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
Review comment:
If no exit span, you don't have the ref in this span.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
wu-sheng commented on issue #4151: [test/plugin] immigrate test activemq scenario. URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569723390 Why remove ref? I am confused about your changes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services
wu-sheng commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r361996266
##########
File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
##########
@@ -25,24 +25,8 @@ segmentItems:
- applicationCode: activemq-scenario
segmentSize: ge 2
segments:
- - segmentId: /activemq-scenario/case/activemq
+ - segmentId: not null
spans:
- - operationName: ActiveMQ/Queue/test/Producer
Review comment:
Why remove this? We should have this in the expected data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
aderm commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r361999157
##########
File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {activemq-scenario: nq 0}
+ instances:
+ - {activemq-scenario: nq 0}
+ operationNames:
+ - activemq-scenario: [ActiveMQ/Queue/test/Producer, ActiveMQ/Queue/test/Consumer, /activemq-scenario/case/activemq]
+ heartbeat: []
+segmentItems:
+- applicationCode: activemq-scenario
+ segmentSize: ge 2
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /activemq-scenario/case/activemq
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 1
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ tags:
+ - {key: url, value: 'http://localhost:8080/activemq-scenario/case/activemq'}
+ - {key: http.method, value: GET}
+ - segmentId: not null
+ spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
Review comment:
producer is exit span，i am not sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
codecov-io edited a comment on issue #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569657596
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=h1) Report
> Merging [#4151](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4151 +/- ##
=======================================
Coverage 27.13% 27.13%
=======================================
Files 1145 1145
Lines 25105 25105
Branches 3631 3631
=======================================
Hits 6812 6812
Misses 17690 17690
Partials 603 603
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=footer). Last update [1ee14fb...8b06f1c](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
codecov-io edited a comment on issue #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569657596
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=h1) Report
> Merging [#4151](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
+ Coverage 27.13% 27.18% +0.04%
==========================================
Files 1145 1145
Lines 25105 25105
Branches 3631 3631
==========================================
+ Hits 6812 6824 +12
+ Misses 17690 17675 -15
- Partials 603 606 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4151/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=footer). Last update [1ee14fb...a0d76c1](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
aderm commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r362031811
##########
File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {activemq-scenario: nq 0}
+ instances:
+ - {activemq-scenario: nq 0}
+ operationNames:
+ - activemq-scenario: [ActiveMQ/Queue/test/Producer, ActiveMQ/Queue/test/Consumer, /activemq-scenario/case/activemq]
+ heartbeat: []
+segmentItems:
+- applicationCode: activemq-scenario
+ segmentSize: ge 2
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /activemq-scenario/case/activemq
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 1
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ tags:
+ - {key: url, value: 'http://localhost:8080/activemq-scenario/case/activemq'}
+ - {key: http.method, value: GET}
+ - segmentId: not null
+ spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
Review comment:
> If no exit span, you don't have the ref in this span.
This doesn't understand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
codecov-io commented on issue #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569657596
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=h1) Report
> Merging [#4151](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
+ Coverage 27.13% 27.18% +0.04%
==========================================
Files 1145 1145
Lines 25105 25105
Branches 3631 3631
==========================================
+ Hits 6812 6824 +12
+ Misses 17690 17675 -15
- Partials 603 606 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4151/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=footer). Last update [1ee14fb...6342994](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
dmsolr commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r361968843
##########
File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {activemq-scenario: nq 0}
+ instances:
+ - {activemq-scenario: nq 0}
+ operationNames:
+ - activemq-scenario: [ActiveMQ/Queue/test/Producer, ActiveMQ/Queue/test/Consumer, /activemq-scenario/case/activemq]
Review comment:
We don't need to register the `ExitSpan`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
codecov-io edited a comment on issue #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569657596
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=h1) Report
> Merging [#4151](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/51e74ca4c41d0869a6fe6ad3715683f45d200da3?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
+ Coverage 26.98% 27.03% +0.04%
==========================================
Files 1147 1147
Lines 25141 25141
Branches 3641 3641
==========================================
+ Hits 6785 6797 +12
+ Misses 17754 17739 -15
- Partials 602 605 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4151/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=footer). Last update [51e74ca...f179ea5](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
codecov-io edited a comment on issue #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#issuecomment-569657596
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=h1) Report
> Merging [#4151](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
+ Coverage 27.13% 27.18% +0.04%
==========================================
Files 1145 1145
Lines 25105 25105
Branches 3631 3631
==========================================
+ Hits 6812 6824 +12
+ Misses 17690 17675 -15
- Partials 603 606 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4151/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=footer). Last update [1ee14fb...8b06f1c](https://codecov.io/gh/apache/skywalking/pull/4151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
dmsolr commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario. URL: https://github.com/apache/skywalking/pull/4151#discussion_r361968463 ########## File path: docs/en/setup/service-agent/java-agent/Supported-list.md ########## @@ -43,6 +43,7 @@ * [Armeria](https://github.com/line/armeria) 0.63.0 -> 0.97.0 * MQ * [RocketMQ](https://github.com/apache/rocketmq) 4.x + * [ActiveMQ](https://github.com/apache/activemq) 5.10.0 -> 5.15.4 * [Kafka](http://kafka.apache.org) 0.11.0.0 -> 1.0 * [ActiveMQ](https://github.com/apache/activemq) 5.x Review comment: duplicated! :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services
wu-sheng merged pull request #4151: [test/plugin] immigrate test activemq scenario. URL: https://github.com/apache/skywalking/pull/4151 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services
wu-sheng commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r361996836
##########
File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {activemq-scenario: nq 0}
+ instances:
+ - {activemq-scenario: nq 0}
+ operationNames:
+ - activemq-scenario: [ActiveMQ/Queue/test/Producer, ActiveMQ/Queue/test/Consumer, /activemq-scenario/case/activemq]
+ heartbeat: []
+segmentItems:
+- applicationCode: activemq-scenario
+ segmentSize: ge 2
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /activemq-scenario/case/activemq
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 1
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ tags:
+ - {key: url, value: 'http://localhost:8080/activemq-scenario/case/activemq'}
+ - {key: http.method, value: GET}
+ - segmentId: not null
+ spans:
+ - operationName: ActiveMQ/Queue/test/Consumer
Review comment:
No producer span, I am not sure why you remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services