You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Noorul Islam K M <no...@collab.net> on 2010/12/22 06:27:29 UTC
[PATCH] Fix syntax inconsistency and update comments.
Find attached minor patch which makes 'if' syntax consistent and also
some comment improvements.
Log
[[[
Fix syntax inconsistency and update comments.
* libsvn_client/locking_commands.c
(organize_lock_targets): Fix syntax inconsistency. Update comments.
Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]
Thanks and Regards
Noorul
Re: [PATCH] Fix syntax inconsistency and update comments.
Posted by Noorul Islam K M <no...@collab.net>.
John Szakmeister <jo...@szakmeister.net> writes:
> On Tue, Jan 4, 2011 at 3:53 AM, Noorul Islam K M <no...@collab.net> wrote:
> [snip]
>
>> Just reminding so that someone take a look at this patch. I know this is
>> not so important but still wonder why such a trivial patch takes time to
>> get reviewed and committed.
>
> I think everyone is just getting back into the grind after the
> holidays. I took a look at it committed it. See r1054989.
>
> Thanks!
>
Thank you!
- Noorul
Re: [PATCH] Fix syntax inconsistency and update comments.
Posted by John Szakmeister <jo...@szakmeister.net>.
On Tue, Jan 4, 2011 at 3:53 AM, Noorul Islam K M <no...@collab.net> wrote:
[snip]
> Just reminding so that someone take a look at this patch. I know this is
> not so important but still wonder why such a trivial patch takes time to
> get reviewed and committed.
I think everyone is just getting back into the grind after the
holidays. I took a look at it committed it. See r1054989.
Thanks!
-John
Re: [PATCH] Fix syntax inconsistency and update comments.
Posted by Noorul Islam K M <no...@collab.net>.
Noorul Islam K M <no...@collab.net> writes:
> Noorul Islam K M <no...@collab.net> writes:
>
>> "Hyrum K. Wright" <hy...@mail.utexas.edu> writes:
>>
>>> On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M <no...@collab.net> wrote:
>>>
>>>>
>>>> Find attached minor patch which makes 'if' syntax consistent and also
>>>> some comment improvements.
>>>>
>>>> Log
>>>>
>>>> [[[
>>>>
>>>> Fix syntax inconsistency and update comments.
>>>>
>>>> * libsvn_client/locking_commands.c
>>>> (organize_lock_targets): Fix syntax inconsistency. Update comments.
>>>
>>> *What* about the syntax inconsistency are you fixing? White space?
>>> Function names? Use of braces? (I can tell by looking at the patch,
>>> but a more informative log message would be nice.)
>>>
>>> Same with "update comments". Update them in what way?
>>>
>>
>> Please find updated log message.
>>
>> [[[
>>
>> Fix syntax inconsistency and update comments.
>>
>> * libsvn_client/locking_commands.c
>> (organize_lock_targets): Fix syntax inconsistency by removing
>> unnecessary braces from 'if' block. Update comments to reflect new
>> function names used.
>>
>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>> ]]]
>>
>
> I was thinking that this one is a trivial fix.
>
Just reminding so that someone take a look at this patch. I know this is
not so important but still wonder why such a trivial patch takes time to
get reviewed and committed.
Thanks and Regards
Noorul
Re: [PATCH] Fix syntax inconsistency and update comments.
Posted by Noorul Islam K M <no...@collab.net>.
Noorul Islam K M <no...@collab.net> writes:
> "Hyrum K. Wright" <hy...@mail.utexas.edu> writes:
>
>> On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M <no...@collab.net> wrote:
>>
>>>
>>> Find attached minor patch which makes 'if' syntax consistent and also
>>> some comment improvements.
>>>
>>> Log
>>>
>>> [[[
>>>
>>> Fix syntax inconsistency and update comments.
>>>
>>> * libsvn_client/locking_commands.c
>>> (organize_lock_targets): Fix syntax inconsistency. Update comments.
>>
>> *What* about the syntax inconsistency are you fixing? White space?
>> Function names? Use of braces? (I can tell by looking at the patch,
>> but a more informative log message would be nice.)
>>
>> Same with "update comments". Update them in what way?
>>
>
> Please find updated log message.
>
> [[[
>
> Fix syntax inconsistency and update comments.
>
> * libsvn_client/locking_commands.c
> (organize_lock_targets): Fix syntax inconsistency by removing
> unnecessary braces from 'if' block. Update comments to reflect new
> function names used.
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>
I was thinking that this one is a trivial fix.
Thanks and Regards
Noorul
Re: [PATCH] Fix syntax inconsistency and update comments.
Posted by Noorul Islam K M <no...@collab.net>.
"Hyrum K. Wright" <hy...@mail.utexas.edu> writes:
> On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M <no...@collab.net> wrote:
>
>>
>> Find attached minor patch which makes 'if' syntax consistent and also
>> some comment improvements.
>>
>> Log
>>
>> [[[
>>
>> Fix syntax inconsistency and update comments.
>>
>> * libsvn_client/locking_commands.c
>> (organize_lock_targets): Fix syntax inconsistency. Update comments.
>
> *What* about the syntax inconsistency are you fixing? White space?
> Function names? Use of braces? (I can tell by looking at the patch,
> but a more informative log message would be nice.)
>
> Same with "update comments". Update them in what way?
>
Please find updated log message.
[[[
Fix syntax inconsistency and update comments.
* libsvn_client/locking_commands.c
(organize_lock_targets): Fix syntax inconsistency by removing
unnecessary braces from 'if' block. Update comments to reflect new
function names used.
Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]
Thanks and Regards
Noorul
Re: [PATCH] Fix syntax inconsistency and update comments.
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M <no...@collab.net> wrote:
>
> Find attached minor patch which makes 'if' syntax consistent and also
> some comment improvements.
>
> Log
>
> [[[
>
> Fix syntax inconsistency and update comments.
>
> * libsvn_client/locking_commands.c
> (organize_lock_targets): Fix syntax inconsistency. Update comments.
*What* about the syntax inconsistency are you fixing? White space?
Function names? Use of braces? (I can tell by looking at the patch,
but a more informative log message would be nice.)
Same with "update comments". Update them in what way?
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>
> Thanks and Regards
> Noorul
>
>
> Index: libsvn_client/locking_commands.c
> ===================================================================
> --- libsvn_client/locking_commands.c (revision 1051763)
> +++ libsvn_client/locking_commands.c (working copy)
> @@ -191,18 +191,15 @@
>
> /* Get the common parent and all paths */
> if (url_mode)
> - {
> SVN_ERR(svn_uri_condense_targets(common_parent_url, &rel_targets,
> targets, TRUE, pool, pool));
> - }
> else
> - {
> SVN_ERR(svn_dirent_condense_targets(common_parent_url, &rel_targets,
> targets, TRUE, pool, pool));
> - }
>
> - /* svn_path_condense_targets leaves paths empty if TARGETS only had
> - 1 member, so we special case that. */
> + /* svn_uri_condense_targets and svn_dirent_condense_targets leaves
> + URLs/paths empty if TARGETS only had 1 member, so we special case
> + that. */
> if (apr_is_empty_array(rel_targets))
> {
> const char *parent, *base;
> @@ -273,8 +270,8 @@
> SVN_ERR(svn_uri_condense_targets(&common_url, &rel_urls, urls,
> FALSE, pool, pool));
>
> - /* svn_path_condense_targets leaves paths empty if TARGETS only had
> - 1 member, so we special case that (again). */
> + /* svn_uri_condense_targets leaves URLs empty if TARGETS only
> + had 1 member, so we special case that (again). */
> if (apr_is_empty_array(rel_urls))
> {
> const char *base_name = svn_uri_basename(common_url, pool);
>
>