[GitHub] [skywalking] wu-sheng opened a new pull request #4059: Remove the local/exit span register mechanism in Java agent scenario

[GitBox <gi...@apache.org>]

wu-sheng opened a new pull request #4059: Remove the local/exit span register mechanism in Java agent scenario
URL: https://github.com/apache/skywalking/pull/4059
 
 
   Resolves #4056
   
   **Key**, reduce the load of register and amount of operation id. Also, reduce the agent memory cost.
   At the same time, the local span and exit span plugins will not concern about `parameter in the op name` causing `too many registers` issue.
   
   @kezhenxu94 Could you review and run a test locally? Especially for the plugin you are working on, `Runnable` case I mean. If inside `runnable`, an RPC is called, the endpoint dependency should show that endpoint still depends on the parent endpoint(RPC in the parent thread of the runnable). If no parent thread exist, as this thread is a local task(timer), then the endpoint should depend on the user. Could you verify these two cases? And confirm no local span and exit span register happen, check through
   1. No local and exit operation name in the endpoint inventory
   1. No warning log, like this `Unexpected endpoint register, endpoint isn't detected from server side. ` ,happens.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services