You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/01/18 12:01:21 UTC
Review Request 55672: AMBARI-19607:User is not able to set the start
and end date for a coordinator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55672/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-19607
https://issues.apache.org/jira/browse/AMBARI-19607
Repository: ambari
Description
-------
User is not able to set the start and end date for a coordinator.
Steps to reproduce :
1) Open the coordinator.
2) Switch the start date type to expression.
3) Switch back start date type to Date.
4) Select the date using date picker. UI is throwing the error "This field must be in the format of MM/DD/YYYY hh:mm A"
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 26b94cf
contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 541104d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs dc69382
Diff: https://reviews.apache.org/r/55672/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 55672: AMBARI-19607:User is not able to set the
start and end date for a coordinator
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55672/#review162084
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 18, 2017, 12:01 p.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55672/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 12:01 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19607
> https://issues.apache.org/jira/browse/AMBARI-19607
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User is not able to set the start and end date for a coordinator.
> Steps to reproduce :
> 1) Open the coordinator.
> 2) Switch the start date type to expression.
> 3) Switch back start date type to Date.
> 4) Select the date using date picker. UI is throwing the error "This field must be in the format of MM/DD/YYYY hh:mm A"
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 26b94cf
> contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 541104d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs dc69382
>
> Diff: https://reviews.apache.org/r/55672/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 55672: AMBARI-19607:User is not able to set the
start and end date for a coordinator
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55672/#review162260
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js (line 112)
<https://reviews.apache.org/r/55672/#comment233608>
check if using Map is not a problem in compilation with and ship it.
- Nitiraj Rathore
On Jan. 18, 2017, 3:15 p.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55672/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 3:15 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19607
> https://issues.apache.org/jira/browse/AMBARI-19607
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When switching between Expression and Date options in the date field, added correct date format to the date time picker.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 26b94cf
> contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 541104d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs dc69382
>
> Diff: https://reviews.apache.org/r/55672/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 55672: AMBARI-19607:User is not able to set the
start and end date for a coordinator
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55672/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 3:15 p.m.)
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-19607
https://issues.apache.org/jira/browse/AMBARI-19607
Repository: ambari
Description (updated)
-------
When switching between Expression and Date options in the date field, added correct date format to the date time picker.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 26b94cf
contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 541104d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs dc69382
Diff: https://reviews.apache.org/r/55672/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 55672: AMBARI-19607:User is not able to set the
start and end date for a coordinator
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55672/#review162075
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Jan. 18, 2017, 12:01 p.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55672/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 12:01 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19607
> https://issues.apache.org/jira/browse/AMBARI-19607
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User is not able to set the start and end date for a coordinator.
> Steps to reproduce :
> 1) Open the coordinator.
> 2) Switch the start date type to expression.
> 3) Switch back start date type to Date.
> 4) Select the date using date picker. UI is throwing the error "This field must be in the format of MM/DD/YYYY hh:mm A"
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 26b94cf
> contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 541104d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs dc69382
>
> Diff: https://reviews.apache.org/r/55672/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>