You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/22 18:00:43 UTC
[GitHub] [superset] diegomedina248 opened a new pull request #19313: fix(sql lab): increase the size of the action icons in the history tab
diegomedina248 opened a new pull request #19313:
URL: https://github.com/apache/superset/pull/19313
### SUMMARY
This PR increases the size of the action icons in the SQL Lab history tab to match the rest of the application.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1287" alt="Screen Shot 2022-03-22 at 14 45 03" src="https://user-images.githubusercontent.com/17252075/159543061-f4416c53-3124-42f1-b7fe-eecefc44c9cf.png">
After:
<img width="1283" alt="Screen Shot 2022-03-22 at 14 44 15" src="https://user-images.githubusercontent.com/17252075/159542934-fcaa2b5b-e63d-4bc2-970e-8b3941805c4a.png">
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19313: fix(sql lab): increase the size of the action icons in the history tab
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19313:
URL: https://github.com/apache/superset/pull/19313#issuecomment-1075499163
# [Codecov](https://codecov.io/gh/apache/superset/pull/19313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19313](https://codecov.io/gh/apache/superset/pull/19313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34171d8) into [master](https://codecov.io/gh/apache/superset/commit/7ca10fb770934f78f3df1cc3f47a6613c4c62c13?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ca10fb) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 34171d8 differs from pull request most recent head a22b0f6. Consider uploading reports for the commit a22b0f6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19313 +/- ##
=======================================
Coverage 66.65% 66.65%
=======================================
Files 1672 1672
Lines 64611 64611
Branches 6505 6505
=======================================
Hits 43066 43066
Misses 19862 19862
Partials 1683 1683
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.33% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/QueryTable/index.tsx](https://codecov.io/gh/apache/superset/pull/19313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUvaW5kZXgudHN4) | `68.42% <ø> (ø)` | |
| [superset-frontend/src/views/components/Menu.tsx](https://codecov.io/gh/apache/superset/pull/19313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NvbXBvbmVudHMvTWVudS50c3g=) | `60.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ca10fb...a22b0f6](https://codecov.io/gh/apache/superset/pull/19313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org