You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Datko (JIRA)" <ji...@apache.org> on 2010/08/13 15:03:18 UTC

[jira] Created: (ZOOKEEPER-847) Missing ack-Check in Zookeeper create

Missing ack-Check in Zookeeper create
-------------------------------------

                 Key: ZOOKEEPER-847
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-847
             Project: Zookeeper
          Issue Type: Bug
          Components: java client
    Affects Versions: 3.3.1
            Reporter: Patrick Datko


I watched the source of zookeeper class and i missed an ack-check in the asynchronous version of the create operation. Is there any reason, that in the asynch version is no
check whether the ack is valid, or did someone forget to implement it. It's interesting because we worked on a refactoring of the zookeeper client and don't want to implement a bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-847) Missing acl check in zookeeper create

Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Koch updated ZOOKEEPER-847:
----------------------------------

        Summary: Missing acl check in zookeeper create  (was: Missing ack-Check in Zookeeper create)
    Description: 
I watched the source of the zookeeper class and I missed an acl check in the asynchronous version of the create operation. Is there any reason, that in the asynch version is no
check whether the acl is valid, or did someone forget to implement it. It's interesting because we worked on a refactoring of the zookeeper client and don't want to implement a bug.

The following code is missing:
        if (acl != null && acl.size() == 0) {
            throw new KeeperException.InvalidACLException();
        }


  was:
I watched the source of zookeeper class and i missed an ack-check in the asynchronous version of the create operation. Is there any reason, that in the asynch version is no
check whether the ack is valid, or did someone forget to implement it. It's interesting because we worked on a refactoring of the zookeeper client and don't want to implement a bug.


s/ack/acl/, fixed spelling, added code snippet in question

> Missing acl check in zookeeper create
> -------------------------------------
>
>                 Key: ZOOKEEPER-847
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-847
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.1
>            Reporter: Patrick Datko
>
> I watched the source of the zookeeper class and I missed an acl check in the asynchronous version of the create operation. Is there any reason, that in the asynch version is no
> check whether the acl is valid, or did someone forget to implement it. It's interesting because we worked on a refactoring of the zookeeper client and don't want to implement a bug.
> The following code is missing:
>         if (acl != null && acl.size() == 0) {
>             throw new KeeperException.InvalidACLException();
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.