You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by an...@apache.org on 2018/11/22 10:01:44 UTC

[mynewt-core] branch master updated: hw/mcu/nordic: Fix stop on I2C write

This is an automated email from the ASF dual-hosted git repository.

andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
     new 8055fb2  hw/mcu/nordic: Fix stop on I2C write
8055fb2 is described below

commit 8055fb20ae993e15d293c4d95e01d4fe124c0ab3
Author: Andrzej Kaczmarek <an...@codecoup.pl>
AuthorDate: Wed Nov 21 17:35:46 2018 +0100

    hw/mcu/nordic: Fix stop on I2C write
    
    This seems to be done by mistake in some earlier commit, but we should
    not put stop condition on bus after every write - only if we were asked
    to (or in case of error).
---
 hw/mcu/nordic/nrf52xxx/src/hal_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mcu/nordic/nrf52xxx/src/hal_i2c.c b/hw/mcu/nordic/nrf52xxx/src/hal_i2c.c
index d242bc5..77239de 100644
--- a/hw/mcu/nordic/nrf52xxx/src/hal_i2c.c
+++ b/hw/mcu/nordic/nrf52xxx/src/hal_i2c.c
@@ -366,7 +366,7 @@ hal_i2c_master_write(uint8_t i2c_num, struct hal_i2c_master_data *pdata,
         }
     }
 
-    rc = 0;
+    return 0;
 
 err:
     regs->TASKS_STOP = 1;