You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ma...@apache.org on 2016/08/14 18:46:25 UTC
[13/15] tika git commit: TIKA-1986 Fixed the outdated Bad paramter
test case and removed deadcode in comments
TIKA-1986 Fixed the outdated Bad paramter test case and removed deadcode in comments
Project: http://git-wip-us.apache.org/repos/asf/tika/repo
Commit: http://git-wip-us.apache.org/repos/asf/tika/commit/a1d1a81d
Tree: http://git-wip-us.apache.org/repos/asf/tika/tree/a1d1a81d
Diff: http://git-wip-us.apache.org/repos/asf/tika/diff/a1d1a81d
Branch: refs/heads/TIKA-1508
Commit: a1d1a81d15b287b44041d590d8b124be06af0a19
Parents: f77eb2b
Author: Thamme Gowda <th...@apache.org>
Authored: Sat Aug 13 14:07:11 2016 -0700
Committer: Thamme Gowda <th...@apache.org>
Committed: Sat Aug 13 14:07:11 2016 -0700
----------------------------------------------------------------------
.../java/org/apache/tika/utils/AnnotationUtils.java | 12 ------------
.../org/apache/tika/parser/ParameterizedParserTest.java | 10 ----------
2 files changed, 22 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tika/blob/a1d1a81d/tika-core/src/main/java/org/apache/tika/utils/AnnotationUtils.java
----------------------------------------------------------------------
diff --git a/tika-core/src/main/java/org/apache/tika/utils/AnnotationUtils.java b/tika-core/src/main/java/org/apache/tika/utils/AnnotationUtils.java
index eead096..2ab588e 100644
--- a/tika-core/src/main/java/org/apache/tika/utils/AnnotationUtils.java
+++ b/tika-core/src/main/java/org/apache/tika/utils/AnnotationUtils.java
@@ -134,17 +134,5 @@ public class AnnotationUtils {
//LOG.debug("Param not supplied, field is not mandatory");
}
}
- /*
- //now test that params doesn't contain a field
- //not allowed by this object
- for (String fieldName : params.keySet()) {
- if (! validFieldNames.contains(fieldName)) {
- String msg = String.format(Locale.ROOT,
- "No field '%s' exists for %s",
- fieldName, bean.getClass().getName());
- throw new TikaConfigException(msg);
- }
- }
- */
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/tika/blob/a1d1a81d/tika-core/src/test/java/org/apache/tika/parser/ParameterizedParserTest.java
----------------------------------------------------------------------
diff --git a/tika-core/src/test/java/org/apache/tika/parser/ParameterizedParserTest.java b/tika-core/src/test/java/org/apache/tika/parser/ParameterizedParserTest.java
index 1471504..a9c9a41 100644
--- a/tika-core/src/test/java/org/apache/tika/parser/ParameterizedParserTest.java
+++ b/tika-core/src/test/java/org/apache/tika/parser/ParameterizedParserTest.java
@@ -86,16 +86,6 @@ public class ParameterizedParserTest {
}
@Test
- public void testBadParam() throws Exception {
- try {
- Metadata m = getMetadata("TIKA-1986-bad-parameters.xml");
- fail("should have thrown exception");
- } catch (TikaException e) {
-
- }
- }
-
- @Test
public void testBadValue() throws Exception {
boolean ex = false;
try {