You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Bob Schellink (JIRA)" <ji...@apache.org> on 2010/02/16 12:51:27 UTC
[jira] Resolved: (CLK-626) FormTable does not gracefully handle
NULL Fields
[ https://issues.apache.org/jira/browse/CLK-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink resolved CLK-626.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0
Assignee: Bob Schellink
Thanks, fix checked in. Do note that for read-only columns you can simply use a Column instead of a FieldColumn
> FormTable does not gracefully handle NULL Fields
> ------------------------------------------------
>
> Key: CLK-626
> URL: https://issues.apache.org/jira/browse/CLK-626
> Project: Click
> Issue Type: Improvement
> Components: extras
> Affects Versions: 2.1.0
> Reporter: WarnerJan Veldhuis
> Assignee: Bob Schellink
> Fix For: 2.2.0
>
>
> To be able to have columns in a FormTable that are "display only", ie no fields to edit, I set the Field to null. FieldColumn is perfectly capable of handling NULLs for getField(). It will fallback to the super implementation when a Field is null, and render the data as if it was a Column.
> FormTable however, does that only *partially*. Some parts are checked, some are not.
> Line 283 of FormTable does a good job:
> if (fieldColumn.getField() != null) {
> fieldColumn.getField().setForm(getForm());
> }
> But further down the code, getField() is called and used directly. I would like to see it checked for null. I have modified my local FormTable, and I can find no problems using it like that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.