[GitHub] [skywalking-swck] RolandMa1986 commented on pull request #47: Remove deprecated Kubernetes API dependence

[GitBox <gi...@apache.org>]

RolandMa1986 commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-977473033


   > @RolandMa1986 Thank you for your contribution. As I mentioned, we want to upgrade kubebuilder to v3. I would like to investigate the impact of the API update before reviewing it. Do you have some insights into this task?
   
   @hanahmily I think Upgrade Kubebuilder to v3 doesn't have any conflict with this PR. 
   
   There are 3 parts that will be changed in the Kuberbuilder v3 according to the [upgrading guide](https://book.kubebuilder.io/migration/v2vsv3.html)
   1. PROJECT file' layout. I'm sure what was changed exactly.
   2. Scaffolded tools. The latest Kubebuilder v3.2.0 still uses `controller-tools 0.7.0` which is the same version used in SWCK. So I think that all the generated manifest will be the same.
   3. Go mod dependence. For `controller-runtime` and `k8s.io/api`, I think it depends on which kubebuilder version was used when initializing the PROJECT. But in practice, we just need to consider which Kubernetes version we need to support and choose a compatible version.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org