You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Neha Narkhede (Created) (JIRA)" <ji...@apache.org> on 2012/03/14 19:38:40 UTC
[jira] [Created] (KAFKA-304) Simple Consumer message set behavior
broken on 0.8 branch
Simple Consumer message set behavior broken on 0.8 branch
---------------------------------------------------------
Key: KAFKA-304
URL: https://issues.apache.org/jira/browse/KAFKA-304
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8
Reporter: Neha Narkhede
Assignee: Prashanth Menon
Priority: Critical
The testZKSendWithDeadBroker() test commented out in ProducerTest actually exposes a bug with path KAFKA-240. It seems that even when the broker has some messages for a topic partition, the simple consumer doesn't return those.
I've simplified this test and attached a diff to this bug. Apply it on 0.8 branch to reproduce this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-304) Simple Consumer message set behavior
broken on 0.8 branch
Posted by "Neha Narkhede (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neha Narkhede updated KAFKA-304:
--------------------------------
Attachment: kafka-240-bug.patch
> Simple Consumer message set behavior broken on 0.8 branch
> ---------------------------------------------------------
>
> Key: KAFKA-304
> URL: https://issues.apache.org/jira/browse/KAFKA-304
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Prashanth Menon
> Priority: Critical
> Attachments: kafka-240-bug.patch
>
>
> The testZKSendWithDeadBroker() test commented out in ProducerTest actually exposes a bug with path KAFKA-240. It seems that even when the broker has some messages for a topic partition, the simple consumer doesn't return those.
> I've simplified this test and attached a diff to this bug. Apply it on 0.8 branch to reproduce this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-304) Simple Consumer message set behavior
broken on 0.8 branch
Posted by "Prashanth Menon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229560#comment-13229560 ]
Prashanth Menon commented on KAFKA-304:
---------------------------------------
Hi Neha,
I took a glancing look at the test and I think there might be a mistake. The line that reads: "assertEquals(message, messageSet.next.message)" should actually be "assertEquals(message, messageAndOffset.message)". The former progresses the iterator a second time after the preceeding line so two messages are consumed within one iteration of the loop, wherare the latter looks at one message within the current iteration alone. I'll take a closer look when I get a chance.
> Simple Consumer message set behavior broken on 0.8 branch
> ---------------------------------------------------------
>
> Key: KAFKA-304
> URL: https://issues.apache.org/jira/browse/KAFKA-304
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Prashanth Menon
> Priority: Critical
> Attachments: kafka-240-bug.patch
>
>
> The testZKSendWithDeadBroker() test commented out in ProducerTest actually exposes a bug with path KAFKA-240. It seems that even when the broker has some messages for a topic partition, the simple consumer doesn't return those.
> I've simplified this test and attached a diff to this bug. Apply it on 0.8 branch to reproduce this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KAFKA-304) Simple Consumer message set behavior
broken on 0.8 branch
Posted by "Neha Narkhede (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neha Narkhede resolved KAFKA-304.
---------------------------------
Resolution: Not A Problem
Prashanth, that looks like a bug in the test itself.
> Simple Consumer message set behavior broken on 0.8 branch
> ---------------------------------------------------------
>
> Key: KAFKA-304
> URL: https://issues.apache.org/jira/browse/KAFKA-304
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Prashanth Menon
> Priority: Critical
> Attachments: kafka-240-bug.patch
>
>
> The testZKSendWithDeadBroker() test commented out in ProducerTest actually exposes a bug with path KAFKA-240. It seems that even when the broker has some messages for a topic partition, the simple consumer doesn't return those.
> I've simplified this test and attached a diff to this bug. Apply it on 0.8 branch to reproduce this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-304) Simple Consumer message set behavior
broken on 0.8 branch
Posted by "Neha Narkhede (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neha Narkhede updated KAFKA-304:
--------------------------------
Attachment: (was: kafka-240-bug.patch)
> Simple Consumer message set behavior broken on 0.8 branch
> ---------------------------------------------------------
>
> Key: KAFKA-304
> URL: https://issues.apache.org/jira/browse/KAFKA-304
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Prashanth Menon
> Priority: Critical
>
> The testZKSendWithDeadBroker() test commented out in ProducerTest actually exposes a bug with path KAFKA-240. It seems that even when the broker has some messages for a topic partition, the simple consumer doesn't return those.
> I've simplified this test and attached a diff to this bug. Apply it on 0.8 branch to reproduce this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-304) Simple Consumer message set behavior
broken on 0.8 branch
Posted by "Prashanth Menon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229824#comment-13229824 ]
Prashanth Menon commented on KAFKA-304:
---------------------------------------
Modified the test with the change and it seems to be passing. Can you double-check, Neha? The change is on line 215.
> Simple Consumer message set behavior broken on 0.8 branch
> ---------------------------------------------------------
>
> Key: KAFKA-304
> URL: https://issues.apache.org/jira/browse/KAFKA-304
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Prashanth Menon
> Priority: Critical
> Attachments: kafka-240-bug.patch
>
>
> The testZKSendWithDeadBroker() test commented out in ProducerTest actually exposes a bug with path KAFKA-240. It seems that even when the broker has some messages for a topic partition, the simple consumer doesn't return those.
> I've simplified this test and attached a diff to this bug. Apply it on 0.8 branch to reproduce this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-304) Simple Consumer message set behavior
broken on 0.8 branch
Posted by "Neha Narkhede (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neha Narkhede updated KAFKA-304:
--------------------------------
Attachment: kafka-240-bug.patch
The test creates a topic new-topic with partitions on one broker. The producer sends 2 messages to one partition on that broker. The file message set on that broker returns 2 messages, but simple consumer pulling from the same broker returns only 1 message.
> Simple Consumer message set behavior broken on 0.8 branch
> ---------------------------------------------------------
>
> Key: KAFKA-304
> URL: https://issues.apache.org/jira/browse/KAFKA-304
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Prashanth Menon
> Priority: Critical
>
> The testZKSendWithDeadBroker() test commented out in ProducerTest actually exposes a bug with path KAFKA-240. It seems that even when the broker has some messages for a topic partition, the simple consumer doesn't return those.
> I've simplified this test and attached a diff to this bug. Apply it on 0.8 branch to reproduce this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira