[servicecomb-java-chassis] branch master updated: [SCB-1990] allow disable metrics endpoints by configuration

[li...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new 61a51d9  [SCB-1990] allow disable metrics endpoints by configuration
61a51d9 is described below

commit 61a51d9d7797f6b5219fd4be59e2f64352f15029
Author: wujimin <wu...@huawei.com>
AuthorDate: Fri Jun 5 09:33:27 2020 +0800

    [SCB-1990] allow disable metrics endpoints by configuration
---
 demo/perf/src/main/resources/microservice.yaml                      | 2 ++
 .../org/apache/servicecomb/metrics/core/MetricsBootListener.java    | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/demo/perf/src/main/resources/microservice.yaml b/demo/perf/src/main/resources/microservice.yaml
index bac093e..4a26c08 100644
--- a/demo/perf/src/main/resources/microservice.yaml
+++ b/demo/perf/src/main/resources/microservice.yaml
@@ -45,6 +45,8 @@ servicecomb:
     transport: highway
     transport: rest
   metrics:
+    endpoint:
+      enabled: false
     window_time: 1000
     invocation.latencyDistribution: 0,1,3,10,100
     Consumer.invocation.slow:
diff --git a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsBootListener.java b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsBootListener.java
index ee5e763..9786661 100644
--- a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsBootListener.java
+++ b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsBootListener.java
@@ -26,6 +26,8 @@ import org.apache.servicecomb.metrics.core.publish.HealthCheckerRestPublisher;
 import org.apache.servicecomb.metrics.core.publish.MetricsRestPublisher;
 import org.apache.servicecomb.metrics.core.publish.SlowInvocationLogger;
 
+import com.netflix.config.DynamicPropertyFactory;
+
 public class MetricsBootListener implements BootListener {
   private MetricsBootstrap metricsBootstrap = new MetricsBootstrap();
 
@@ -41,6 +43,10 @@ public class MetricsBootListener implements BootListener {
 
   @Override
   public void onBeforeProducerProvider(BootEvent event) {
+    if (!DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.metrics.endpoint.enabled", true).get()) {
+      return;
+    }
+
     event.getScbEngine().getProducerProviderManager()
         .addProducerMeta("healthEndpoint", new HealthCheckerRestPublisher());