You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/14 15:09:02 UTC

[GitHub] [tvm] guberti opened a new pull request #9007: [microTVM] Bump Arduino SDK versions in Vagrant VM

guberti opened a new pull request #9007:
URL: https://github.com/apache/tvm/pull/9007


   In the past two weeks, a new version of the Arduino SDK (`v0.1.9`) and a new version of the Spresense SDK (`v2.3.0`) have been released. These fix two major bugs that caused problems for TVM (thanks to @mdw-octoml for originally reporting these over six months ago), which lets us remove two ugly hacks.
   
   I'm currently testing these changes on Wolfi to ensure they don't break anything - once all looks good, I'll remove the "draft" status from this pull request. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] guberti closed pull request #9007: [microTVM] Bump Arduino SDK versions in Vagrant VM

Posted by GitBox <gi...@apache.org>.
guberti closed pull request #9007:
URL: https://github.com/apache/tvm/pull/9007


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] guberti commented on pull request #9007: [microTVM] Bump Arduino SDK versions in Vagrant VM

Posted by GitBox <gi...@apache.org>.
guberti commented on pull request #9007:
URL: https://github.com/apache/tvm/pull/9007#issuecomment-1016895251


   This PR is outdated - will close and make a new one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] guberti commented on a change in pull request #9007: [microTVM] Bump Arduino SDK versions in Vagrant VM

Posted by GitBox <gi...@apache.org>.
guberti commented on a change in pull request #9007:
URL: https://github.com/apache/tvm/pull/9007#discussion_r708672791



##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_provision.sh
##########
@@ -45,7 +45,7 @@ ADAFRUIT_BOARDS_URL="https://adafruit.github.io/arduino-board-index/package_adaf
 ESP32_BOARDS_URL="https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_dev_index.json"

Review comment:
       We can't cleanly fix versions for all of the others, but using a git commit hash will work. I'll make that change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] guberti commented on a change in pull request #9007: [microTVM] Bump Arduino SDK versions in Vagrant VM

Posted by GitBox <gi...@apache.org>.
guberti commented on a change in pull request #9007:
URL: https://github.com/apache/tvm/pull/9007#discussion_r708399118



##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh
##########
@@ -30,11 +30,11 @@ fi
 
 board=$1
 
-pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board}
+pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board} -s
 
 if [ $board == "nano33ble" ]; then
     # https://github.com/apache/tvm/issues/8730
     echo "NOTE: skipped test_arduino_rpc_server.py on $board -- known failure"
 else
-    pytest tests/micro/arduino/test_arduino_rpc_server.py --arduino-board=${board}
+    pytest tests/micro/arduino/test_arduino_rpc_server.py --arduino-board=${board} -s

Review comment:
       I'd really like to keep the `-s` flag - doing so would make it *much* easier to understand issues when the pop up on Wolfi.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh commented on a change in pull request #9007: [microTVM] Bump Arduino SDK versions in Vagrant VM

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on a change in pull request #9007:
URL: https://github.com/apache/tvm/pull/9007#discussion_r708393051



##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh
##########
@@ -30,11 +30,11 @@ fi
 
 board=$1
 
-pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board}
+pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board} -s

Review comment:
       revert `-s`?

##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_provision.sh
##########
@@ -45,7 +45,7 @@ ADAFRUIT_BOARDS_URL="https://adafruit.github.io/arduino-board-index/package_adaf
 ESP32_BOARDS_URL="https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_dev_index.json"

Review comment:
       can we fix version for other boards as well?

##########
File path: apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh
##########
@@ -30,11 +30,11 @@ fi
 
 board=$1
 
-pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board}
+pytest tests/micro/arduino/test_arduino_workflow.py --arduino-board=${board} -s
 
 if [ $board == "nano33ble" ]; then
     # https://github.com/apache/tvm/issues/8730
     echo "NOTE: skipped test_arduino_rpc_server.py on $board -- known failure"
 else
-    pytest tests/micro/arduino/test_arduino_rpc_server.py --arduino-board=${board}
+    pytest tests/micro/arduino/test_arduino_rpc_server.py --arduino-board=${board} -s

Review comment:
       same here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org