[GitHub] [incubator-streampark] lvshaokang commented on a diff in pull request #2566: [Improve] Flink version check improvement

["lvshaokang (via GitHub)" <gi...@apache.org>]

lvshaokang commented on code in PR #2566:
URL: https://github.com/apache/incubator-streampark/pull/2566#discussion_r1156998070


##########
streampark-common/src/main/scala/org/apache/streampark/common/conf/FlinkVersion.scala:
##########
@@ -109,6 +109,18 @@ class FlinkVersion(val flinkHome: String) extends java.io.Serializable with Logg
     distJar.head
   }
 
+  def checkVersion(throwable: Boolean = true): Boolean = {

Review Comment:
   ```suggestion
     def checkVersion(throwException: Boolean = true): Boolean = {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org