You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/30 02:22:02 UTC
[GitHub] [druid] gianm opened a new pull request #12005: Retain order in TaskReport maps.
gianm opened a new pull request #12005:
URL: https://github.com/apache/druid/pull/12005
A nice feature that enables tasks with multiple report types to report them in a consistent order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #12005: Retain order in TaskReport maps.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #12005:
URL: https://github.com/apache/druid/pull/12005#issuecomment-1011484187
> Currently, `buildTaskReports()` is always called with only one report and the generated map is never updated. So I don't understand the use case for this PR. Is this supposed to support a new feature that is not yet merged?
Ah, good question! The use case is I was working on a site-specific extension that does generate multiple reports per task. I suppose this change could be useful for anyone else that also has site-specific task types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] liran-funaro commented on pull request #12005: Retain order in TaskReport maps.
Posted by GitBox <gi...@apache.org>.
liran-funaro commented on pull request #12005:
URL: https://github.com/apache/druid/pull/12005#issuecomment-1006518616
Currently, `buildTaskReports()` is always called with only one report and the generated map is never updated.
So I don't understand the use case for this PR. Is this supposed to support a new feature that is not yet merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #12005: Retain order in TaskReport maps.
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #12005:
URL: https://github.com/apache/druid/pull/12005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org