You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/21 03:27:21 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14758: [fix][broker] Fix splitNamespaceBundle api request param

codelipenghui commented on a change in pull request #14758:
URL: https://github.com/apache/pulsar/pull/14758#discussion_r830732516



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
##########
@@ -652,7 +652,7 @@ public void splitNamespaceBundle(
             @PathParam("bundle") String bundleRange,
             @QueryParam("authoritative") @DefaultValue("false") boolean authoritative,
             @QueryParam("unload") @DefaultValue("false") boolean unload,
-            @QueryParam("splitBoundaries") @DefaultValue("") List<Long> splitBoundaries) {
+            @ApiParam("splitBoundaries") List<Long> splitBoundaries) {

Review comment:
       Looks like no test coverage here, @nodece Could you please add a unit test for V1 API?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org