You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Adam Kocoloski (JIRA)" <ji...@apache.org> on 2009/04/28 22:02:30 UTC

[jira] Created: (COUCHDB-337) attachments from old/conflict revisions are not accessible via standalone API

attachments from old/conflict revisions are not accessible via standalone API
-----------------------------------------------------------------------------

                 Key: COUCHDB-337
                 URL: https://issues.apache.org/jira/browse/COUCHDB-337
             Project: CouchDB
          Issue Type: Bug
    Affects Versions: 0.9
            Reporter: Adam Kocoloski
             Fix For: 0.10


Couch ignores rev qs parameter for attachment GETs.  I believe it should not.  Attaching proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (COUCHDB-337) attachments from old/conflict revisions are not accessible via standalone API

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Kocoloski reassigned COUCHDB-337:
--------------------------------------

    Assignee: Adam Kocoloski

> attachments from old/conflict revisions are not accessible via standalone API
> -----------------------------------------------------------------------------
>
>                 Key: COUCHDB-337
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-337
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Adam Kocoloski
>            Assignee: Adam Kocoloski
>             Fix For: 0.10
>
>         Attachments: attachment_revisions.diff, conflict_attachment_replication.diff, replication_test.diff
>
>
> Couch ignores rev qs parameter for attachment GETs.  I believe it should not.  Attaching proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-337) attachments from old/conflict revisions are not accessible via standalone API

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Kocoloski updated COUCHDB-337:
-----------------------------------

    Attachment: conflict_attachment_replication.diff

Hah, I knew the line "% TODO worry about revisions" would come back to bite me eventually!  Here's a patch for the replicator that passes that test.

> attachments from old/conflict revisions are not accessible via standalone API
> -----------------------------------------------------------------------------
>
>                 Key: COUCHDB-337
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-337
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Adam Kocoloski
>             Fix For: 0.10
>
>         Attachments: attachment_revisions.diff, conflict_attachment_replication.diff, replication_test.diff
>
>
> Couch ignores rev qs parameter for attachment GETs.  I believe it should not.  Attaching proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-337) attachments from old/conflict revisions are not accessible via standalone API

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Kocoloski updated COUCHDB-337:
-----------------------------------

    Attachment: attachment_revisions.diff

> attachments from old/conflict revisions are not accessible via standalone API
> -----------------------------------------------------------------------------
>
>                 Key: COUCHDB-337
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-337
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Adam Kocoloski
>             Fix For: 0.10
>
>         Attachments: attachment_revisions.diff
>
>
> Couch ignores rev qs parameter for attachment GETs.  I believe it should not.  Attaching proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-337) attachments from old/conflict revisions are not accessible via standalone API

Posted by "Damien Katz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Damien Katz updated COUCHDB-337:
--------------------------------

    Attachment: replication_test.diff

Here is a replication test to show the failures of replicating conflicts with attachments, which doesn't yet pass with attachment_revisions.diff

> attachments from old/conflict revisions are not accessible via standalone API
> -----------------------------------------------------------------------------
>
>                 Key: COUCHDB-337
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-337
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Adam Kocoloski
>             Fix For: 0.10
>
>         Attachments: attachment_revisions.diff, replication_test.diff
>
>
> Couch ignores rev qs parameter for attachment GETs.  I believe it should not.  Attaching proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (COUCHDB-337) attachments from old/conflict revisions are not accessible via standalone API

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Kocoloski closed COUCHDB-337.
----------------------------------

    Resolution: Fixed

added attachment revision support in r771474
used revisions in attachment repl. in r771480

> attachments from old/conflict revisions are not accessible via standalone API
> -----------------------------------------------------------------------------
>
>                 Key: COUCHDB-337
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-337
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Adam Kocoloski
>            Assignee: Adam Kocoloski
>             Fix For: 0.10
>
>         Attachments: attachment_revisions.diff, conflict_attachment_replication.diff, replication_test.diff
>
>
> Couch ignores rev qs parameter for attachment GETs.  I believe it should not.  Attaching proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.