You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stian Soiland-Reyes <st...@apache.org> on 2016/05/16 07:51:46 UTC
[VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE] Apache
Commons VFS 2.1 rc2)
In Jackrabbit's source code I find JcrUtils added in 2009:
https://github.com/apache/jackrabbit/commit/0882a5cc1ed4ce1cf9d3c6b3a592f97c5772ce25
but Jackrabbit graduated from the incubator in 2006:
http://incubator.apache.org/projects/jackrabbit.html
So presumably the software from Day Software was added before that?
Which to me says this is a pure Apache contribution which is only
covered by the regular "This product includes software developed at
ASF" line.
I'll ask on dev@jackrabbit to be sure.
Here's a suggested NOTICE line, in case we still need it:
------------------------------
commons-vfs2-project/core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java
Adapted from Apache Jackrabbit 2.4.0:
Based on source code originally developed by
Day Software (http://www.day.com/).
------------------------------
We don't need to replicate the ASF self-attribution - see
http://www.apache.org/dev/licensing-howto.html#bundle-asf-product
~
On 13 May 2016 at 17:48, Gary Gregory <ga...@gmail.com> wrote:
> On Fri, May 13, 2016 at 3:13 AM, sebb <se...@gmail.com> wrote:
>
>> On 13 May 2016 at 01:24, Sean Busbey <bu...@apache.org> wrote:
>> > -1 (non-binding)
>> >
>> > bad:
>> >
>> > * LICENSE/NOTICE file is missing a bundled third party reference[1]
>> >
>> > maybe fine:
>> >
>> > * source artifacts mostly match source tag[2]
>> > * build / test from source works[3]
>> >
>> > fine:
>> > * verified signatures and checksums[4]
>> >
>> > [1]:
>> >
>> >
>> core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java
>> >
>> > says it is copied from Apache Jackrabbit 2.4.0, which has a NOTICE.txt
>> file.
>>
>> i.e.
>>
>> http://svn.apache.org/repos/asf/jackrabbit/tags/2.4.0/NOTICE.txt
>>
>> > there is no mention of this in the source repo NOTICE (I would presume
>> the
>> > related test jar would also be wrong).
>>
>> Whether that is needed or not depends on whether the specific file was
>> part of the original source code from Day.
>>
>> The file was added as a part of fixing VFS-392
>>
>> @Gary: can you advise which source files you used to create JcrUtils?
>>
>
> No idea, that was a long time ago. All I can say for sure is that I was
> looking at the Jackrabbit 1.6.5 or earlier sources.
>
> Gary
>
>>
>> > [2]:
>> >
>> > The source tag contains an additional module 'sandbox' that is not in
>> the source artifact.
>> >
>> > I am not sure if this is intentional, but it looks like it is.
>> >
>> > [3]:
>> >
>> > Related to [2], if you run `mvn verify` things are fine, but if you use
>> the sandbox profile,
>> > via `mvn -Pinclude-sandbox verify`, things fall over because the above
>> mentioned module
>> > is missing.
>> >
>> > [4]:
>> >
>> > everything properly checks out, but the format of the md5 file was
>> different for the artifacts in
>> > dist.apache compared to repository.apache.
>> >
>> > On 2016-05-11 20:29, Josh Elser <el...@apache.org> wrote:
>> >> All,
>> >>
>> >> Please consider the following for Apache Commons VFS2 version 2.1 (rc2).
>> >>
>> >> Maven repository:
>> >>
>> https://repository.apache.org/content/repositories/orgapachecommons-1166
>> >> Artifacts: https://dist.apache.org/repos/dist/dev/commons/vfs/ r13608
>> >>
>> >> MD5 commons-vfs-distribution-2.1-bin.tar.gz
>> >> 8cc35a3169e1faee727c5af94c7dd904
>> >> SHA1 commons-vfs-distribution-2.1-bin.tar.gz
>> >> 72b7557c4e8b1789b8aa0a9c1e0cb2c9daecec30
>> >> MD5 commons-vfs-distribution-2.1-src.tar.gz
>> >> a182ac642874e85fbc7d1086f7663482
>> >> SHA1 commons-vfs-distribution-2.1-src.tar.gz
>> >> e42ac2053deb314277213e43f6f1d6b43eff3de9
>> >>
>> >> MD5 commons-vfs-distribution-2.1-bin.zip
>> b512a45c63d824eef826f174fd7a9245
>> >> SHA1 commons-vfs-distribution-2.1-bin.zip
>> >> 886cb5a430da58b3a68e2abf297b6f735d3ffaf0
>> >> MD5 commons-vfs-distribution-2.1-src.zip
>> 29645a0ad091c15b2cf76b619c33069f
>> >> SHA1 commons-vfs-distribution-2.1-src.zip
>> >> 5824cf4d802865b5e93ff62c90affa58df6c4384
>> >>
>> >> Signed with 4677D66C from
>> >> https://dist.apache.org/repos/dist/release/commons/KEYS
>> >>
>> >> SVN tag is available at
>> >>
>> https://svn.apache.org/repos/asf/commons/proper/vfs/tags/commons-vfs2-project-2.1-rc2/
>> >> r1743451
>> >>
>> >> Staged Maven website:
>> >> http://home.apache.org/~elserj/commons/commons-vfs-2.1/
>> >>
>> >> All reports are available in the provided staged Maven site (see
>> "Project
>> >> Reports" at the root-level as well as under each sub-module).
>> JIRA-generated
>> >> release notes are available in the dist.a.o "Artifacts" repository. Unit
>> >> tests pass and the RC was built util JDK6.
>> >>
>> >> (For Sebb) A direct Clirr link
>> >>
>> http://home.apache.org/~elserj/commons/commons-vfs-2.1/commons-vfs2/clirr-report.html
>> >>
>> >> Changes since rc1:
>> >>
>> >> * Fixed more compatibility concerns against 2.0 (thanks, Greg)
>> >> * Improved release notes (thanks, Sebb)
>> >>
>> >> This vote will be open for 72-hours, 2016/05/14 0400 UTC.
>> >>
>> >> [ ] +1 Release these artifacts as version 2.1
>> >> [ ] 0 OK, but...
>> >> [ ] -1 I oppose these artifacts as version 2.1 because..
>> >>
>> >> - Josh
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by Josh Elser <el...@apache.org>.
Stian Soiland-Reyes wrote:
>>>>> >>>> I'll ask on dev@jackrabbit to be sure.
>> >
>> > Agreed - so I've tracked it ashttps://issues.apache.org/jira/browse/VFS-611
>> >
>> > Could you assign it to me so I can mark it as In Progress?
>
> Tried, but cannot find you as an assign target.
>
> BTW, there is a sibling file which also was derived from JackRabbit:
>
> JackrabbitMain.java
>
> I've not checked when this was added to the JR repo.
>
Took care of this :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE] Apache Commons VFS 2.1 rc2)
Posted by Sean Busbey <bu...@apache.org>.
On 2016-05-16 08:29, Josh Elser <el...@apache.org> wrote:
> +cc busbey (in case he misses this discuss, otherwise)
>
> Does this make sense to you? I'm sure you have a better understanding
> than I do at the fringes of licensing @ the ASF :)
>
> tl;dr Those copied files from jackrabbit were added after the code was
> already graduated from Incubator, thus, the original "spirit" of the
> NOTICE (being that *some* code came from "Day Software") is definitively
> known to not apply.
>
I replied on the JIRA, but for completeness I'll paraphrase here.
It sounds like we have everything covered for NOTICE about the JackRabbit sources. I'd recommend adding a comment to the copied files that points at VFS-611 so that in future reviews there's an easy indicator that we've done due diligence.
Thanks everyone for taking care of this promptly!
--
busbey
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by Josh Elser <el...@apache.org>.
+cc busbey (in case he misses this discuss, otherwise)
Does this make sense to you? I'm sure you have a better understanding
than I do at the fringes of licensing @ the ASF :)
tl;dr Those copied files from jackrabbit were added after the code was
already graduated from Incubator, thus, the original "spirit" of the
NOTICE (being that *some* code came from "Day Software") is definitively
known to not apply.
Stian Soiland-Reyes wrote:
> JackrabbitMain seems to be based on jackrabbit-standalone module
>
> https://github.com/apache/jackrabbit/blob/1.5/jackrabbit-standalone/src/main/java/org/apache/jackrabbit/standalone/Main.java
>
> which starts in 2008:
>
> https://github.com/apache/jackrabbit/commit/de58b89320ed768a89035197b46f1486b35d430d
>
> On 16 May 2016 at 11:57, sebb<se...@gmail.com> wrote:
>> On 16 May 2016 at 10:56, Stian Soiland-Reyes<st...@apache.org> wrote:
>>> On 16 May 2016 at 10:10, sebb<se...@gmail.com> wrote:
>>>
>>>> Ignore that, I see you found the actual source file,
>>>> so clearly it is not from the original Day contribution.
>>>>
>>>> I was mislead by the comments in the source which implied it came from
>>>> various sources.
>>>> It would be helpful to identify the actual sources in the JIRA and VFS
>>>> once they have been established (not a blocker IMO)
>>>>
>>>>>> I'll ask on dev@jackrabbit to be sure.
>>> Agreed - so I've tracked it as https://issues.apache.org/jira/browse/VFS-611
>>>
>>> Could you assign it to me so I can mark it as In Progress?
>> Tried, but cannot find you as an assign target.
>>
>> BTW, there is a sibling file which also was derived from JackRabbit:
>>
>> JackrabbitMain.java
>>
>> I've not checked when this was added to the JR repo.
>>
>>> --
>>> Stian Soiland-Reyes
>>> Apache Taverna (incubating), Apache Commons RDF (incubating)
>>> http://orcid.org/0000-0001-9842-9718
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by Stian Soiland-Reyes <st...@apache.org>.
See https://lists.apache.org/thread.html/Zk01ufa8icmfvo8
It should be Jackrabbit who best decides what is covered by what in the
NOTICE file; however evidence so far is strongly showing JcrUtils to be IP
clean not needing any NOTICE; and so I would suggest continuing with the
RC2 vote as is. If Jackrabbit responds differently, then we can do a 2.1.1
with modified NOTICE
On 17 May 2016 5:32 a.m., "Dave Fisher" <da...@comcast.net> wrote:
> Just a suggestion. Ask on the jackrabbit Dev list.
>
> Regards,
> Dave
>
> Sent from my iPhone
>
> > On May 16, 2016, at 5:28 AM, Stian Soiland-Reyes <st...@apache.org>
> wrote:
> >
> > JackrabbitMain seems to be based on jackrabbit-standalone module
> >
> >
> https://github.com/apache/jackrabbit/blob/1.5/jackrabbit-standalone/src/main/java/org/apache/jackrabbit/standalone/Main.java
> >
> > which starts in 2008:
> >
> >
> https://github.com/apache/jackrabbit/commit/de58b89320ed768a89035197b46f1486b35d430d
> >
> >> On 16 May 2016 at 11:57, sebb <se...@gmail.com> wrote:
> >>> On 16 May 2016 at 10:56, Stian Soiland-Reyes <st...@apache.org> wrote:
> >>>> On 16 May 2016 at 10:10, sebb <se...@gmail.com> wrote:
> >>>>
> >>>> Ignore that, I see you found the actual source file,
> >>>> so clearly it is not from the original Day contribution.
> >>>>
> >>>> I was mislead by the comments in the source which implied it came from
> >>>> various sources.
> >>>> It would be helpful to identify the actual sources in the JIRA and VFS
> >>>> once they have been established (not a blocker IMO)
> >>>>
> >>>>>> I'll ask on dev@jackrabbit to be sure.
> >>>
> >>> Agreed - so I've tracked it as
> https://issues.apache.org/jira/browse/VFS-611
> >>>
> >>> Could you assign it to me so I can mark it as In Progress?
> >>
> >> Tried, but cannot find you as an assign target.
> >>
> >> BTW, there is a sibling file which also was derived from JackRabbit:
> >>
> >> JackrabbitMain.java
> >>
> >> I've not checked when this was added to the JR repo.
> >>
> >>> --
> >>> Stian Soiland-Reyes
> >>> Apache Taverna (incubating), Apache Commons RDF (incubating)
> >>> http://orcid.org/0000-0001-9842-9718
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
> > --
> > Stian Soiland-Reyes
> > Apache Taverna (incubating), Apache Commons RDF (incubating)
> > http://orcid.org/0000-0001-9842-9718
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE] Apache Commons VFS 2.1 rc2)
Posted by Dave Fisher <da...@comcast.net>.
Just a suggestion. Ask on the jackrabbit Dev list.
Regards,
Dave
Sent from my iPhone
> On May 16, 2016, at 5:28 AM, Stian Soiland-Reyes <st...@apache.org> wrote:
>
> JackrabbitMain seems to be based on jackrabbit-standalone module
>
> https://github.com/apache/jackrabbit/blob/1.5/jackrabbit-standalone/src/main/java/org/apache/jackrabbit/standalone/Main.java
>
> which starts in 2008:
>
> https://github.com/apache/jackrabbit/commit/de58b89320ed768a89035197b46f1486b35d430d
>
>> On 16 May 2016 at 11:57, sebb <se...@gmail.com> wrote:
>>> On 16 May 2016 at 10:56, Stian Soiland-Reyes <st...@apache.org> wrote:
>>>> On 16 May 2016 at 10:10, sebb <se...@gmail.com> wrote:
>>>>
>>>> Ignore that, I see you found the actual source file,
>>>> so clearly it is not from the original Day contribution.
>>>>
>>>> I was mislead by the comments in the source which implied it came from
>>>> various sources.
>>>> It would be helpful to identify the actual sources in the JIRA and VFS
>>>> once they have been established (not a blocker IMO)
>>>>
>>>>>> I'll ask on dev@jackrabbit to be sure.
>>>
>>> Agreed - so I've tracked it as https://issues.apache.org/jira/browse/VFS-611
>>>
>>> Could you assign it to me so I can mark it as In Progress?
>>
>> Tried, but cannot find you as an assign target.
>>
>> BTW, there is a sibling file which also was derived from JackRabbit:
>>
>> JackrabbitMain.java
>>
>> I've not checked when this was added to the JR repo.
>>
>>> --
>>> Stian Soiland-Reyes
>>> Apache Taverna (incubating), Apache Commons RDF (incubating)
>>> http://orcid.org/0000-0001-9842-9718
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons RDF (incubating)
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by Stian Soiland-Reyes <st...@apache.org>.
JackrabbitMain seems to be based on jackrabbit-standalone module
https://github.com/apache/jackrabbit/blob/1.5/jackrabbit-standalone/src/main/java/org/apache/jackrabbit/standalone/Main.java
which starts in 2008:
https://github.com/apache/jackrabbit/commit/de58b89320ed768a89035197b46f1486b35d430d
On 16 May 2016 at 11:57, sebb <se...@gmail.com> wrote:
> On 16 May 2016 at 10:56, Stian Soiland-Reyes <st...@apache.org> wrote:
>> On 16 May 2016 at 10:10, sebb <se...@gmail.com> wrote:
>>
>>> Ignore that, I see you found the actual source file,
>>> so clearly it is not from the original Day contribution.
>>>
>>> I was mislead by the comments in the source which implied it came from
>>> various sources.
>>> It would be helpful to identify the actual sources in the JIRA and VFS
>>> once they have been established (not a blocker IMO)
>>>
>>>>> I'll ask on dev@jackrabbit to be sure.
>>
>> Agreed - so I've tracked it as https://issues.apache.org/jira/browse/VFS-611
>>
>> Could you assign it to me so I can mark it as In Progress?
>
> Tried, but cannot find you as an assign target.
>
> BTW, there is a sibling file which also was derived from JackRabbit:
>
> JackrabbitMain.java
>
> I've not checked when this was added to the JR repo.
>
>> --
>> Stian Soiland-Reyes
>> Apache Taverna (incubating), Apache Commons RDF (incubating)
>> http://orcid.org/0000-0001-9842-9718
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by sebb <se...@gmail.com>.
On 16 May 2016 at 10:56, Stian Soiland-Reyes <st...@apache.org> wrote:
> On 16 May 2016 at 10:10, sebb <se...@gmail.com> wrote:
>
>> Ignore that, I see you found the actual source file,
>> so clearly it is not from the original Day contribution.
>>
>> I was mislead by the comments in the source which implied it came from
>> various sources.
>> It would be helpful to identify the actual sources in the JIRA and VFS
>> once they have been established (not a blocker IMO)
>>
>>>> I'll ask on dev@jackrabbit to be sure.
>
> Agreed - so I've tracked it as https://issues.apache.org/jira/browse/VFS-611
>
> Could you assign it to me so I can mark it as In Progress?
Tried, but cannot find you as an assign target.
BTW, there is a sibling file which also was derived from JackRabbit:
JackrabbitMain.java
I've not checked when this was added to the JR repo.
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons RDF (incubating)
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by Stian Soiland-Reyes <st...@apache.org>.
On 16 May 2016 at 10:10, sebb <se...@gmail.com> wrote:
> Ignore that, I see you found the actual source file,
> so clearly it is not from the original Day contribution.
>
> I was mislead by the comments in the source which implied it came from
> various sources.
> It would be helpful to identify the actual sources in the JIRA and VFS
> once they have been established (not a blocker IMO)
>
>>> I'll ask on dev@jackrabbit to be sure.
Agreed - so I've tracked it as https://issues.apache.org/jira/browse/VFS-611
Could you assign it to me so I can mark it as In Progress?
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by sebb <se...@gmail.com>.
On 16 May 2016 at 10:05, sebb <se...@gmail.com> wrote:
> On 16 May 2016 at 08:51, Stian Soiland-Reyes <st...@apache.org> wrote:
>> In Jackrabbit's source code I find JcrUtils added in 2009:
>>
>> https://github.com/apache/jackrabbit/commit/0882a5cc1ed4ce1cf9d3c6b3a592f97c5772ce25
>>
>> but Jackrabbit graduated from the incubator in 2006:
>>
>> http://incubator.apache.org/projects/jackrabbit.html
>>
>>
>> So presumably the software from Day Software was added before that?
>
> Yes.
>
>> Which to me says this is a pure Apache contribution which is only
>> covered by the regular "This product includes software developed at
>> ASF" line.
>
> That depends on which source files were used.
> Were they ones which came from Day originally?
> Or new ones?
Ignore that, I see you found the actual source file,
so clearly it is not from the original Day contribution.
I was mislead by the comments in the source which implied it came from
various sources.
It would be helpful to identify the actual sources in the JIRA and VFS
once they have been established (not a blocker IMO)
>> I'll ask on dev@jackrabbit to be sure.
>>
>>
>> Here's a suggested NOTICE line, in case we still need it:
>>
>> ------------------------------
>> commons-vfs2-project/core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java
>> Adapted from Apache Jackrabbit 2.4.0:
>>
>> Based on source code originally developed by
>> Day Software (http://www.day.com/).
>> ------------------------------
>
> The NOTICE file is only for *required* attributions.
> We should not add any text 'just in case'
>
> In any case, I'm not sure that the JackRabbit NOTICE file needs to
> contain the "Based on ..." paragraph.
> Is that para actually *required*?
>
>>
>> We don't need to replicate the ASF self-attribution - see
>> http://www.apache.org/dev/licensing-howto.html#bundle-asf-product
>>
>>
>> ~
>>
>> On 13 May 2016 at 17:48, Gary Gregory <ga...@gmail.com> wrote:
>>> On Fri, May 13, 2016 at 3:13 AM, sebb <se...@gmail.com> wrote:
>>>
>>>> On 13 May 2016 at 01:24, Sean Busbey <bu...@apache.org> wrote:
>>>> > -1 (non-binding)
>>>> >
>>>> > bad:
>>>> >
>>>> > * LICENSE/NOTICE file is missing a bundled third party reference[1]
>>>> >
>>>> > maybe fine:
>>>> >
>>>> > * source artifacts mostly match source tag[2]
>>>> > * build / test from source works[3]
>>>> >
>>>> > fine:
>>>> > * verified signatures and checksums[4]
>>>> >
>>>> > [1]:
>>>> >
>>>> >
>>>> core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java
>>>> >
>>>> > says it is copied from Apache Jackrabbit 2.4.0, which has a NOTICE.txt
>>>> file.
>>>>
>>>> i.e.
>>>>
>>>> http://svn.apache.org/repos/asf/jackrabbit/tags/2.4.0/NOTICE.txt
>>>>
>>>> > there is no mention of this in the source repo NOTICE (I would presume
>>>> the
>>>> > related test jar would also be wrong).
>>>>
>>>> Whether that is needed or not depends on whether the specific file was
>>>> part of the original source code from Day.
>>>>
>>>> The file was added as a part of fixing VFS-392
>>>>
>>>> @Gary: can you advise which source files you used to create JcrUtils?
>>>>
>>>
>>> No idea, that was a long time ago. All I can say for sure is that I was
>>> looking at the Jackrabbit 1.6.5 or earlier sources.
>>>
>>> Gary
>>>
>>>>
>>>> > [2]:
>>>> >
>>>> > The source tag contains an additional module 'sandbox' that is not in
>>>> the source artifact.
>>>> >
>>>> > I am not sure if this is intentional, but it looks like it is.
>>>> >
>>>> > [3]:
>>>> >
>>>> > Related to [2], if you run `mvn verify` things are fine, but if you use
>>>> the sandbox profile,
>>>> > via `mvn -Pinclude-sandbox verify`, things fall over because the above
>>>> mentioned module
>>>> > is missing.
>>>> >
>>>> > [4]:
>>>> >
>>>> > everything properly checks out, but the format of the md5 file was
>>>> different for the artifacts in
>>>> > dist.apache compared to repository.apache.
>>>> >
>>>> > On 2016-05-11 20:29, Josh Elser <el...@apache.org> wrote:
>>>> >> All,
>>>> >>
>>>> >> Please consider the following for Apache Commons VFS2 version 2.1 (rc2).
>>>> >>
>>>> >> Maven repository:
>>>> >>
>>>> https://repository.apache.org/content/repositories/orgapachecommons-1166
>>>> >> Artifacts: https://dist.apache.org/repos/dist/dev/commons/vfs/ r13608
>>>> >>
>>>> >> MD5 commons-vfs-distribution-2.1-bin.tar.gz
>>>> >> 8cc35a3169e1faee727c5af94c7dd904
>>>> >> SHA1 commons-vfs-distribution-2.1-bin.tar.gz
>>>> >> 72b7557c4e8b1789b8aa0a9c1e0cb2c9daecec30
>>>> >> MD5 commons-vfs-distribution-2.1-src.tar.gz
>>>> >> a182ac642874e85fbc7d1086f7663482
>>>> >> SHA1 commons-vfs-distribution-2.1-src.tar.gz
>>>> >> e42ac2053deb314277213e43f6f1d6b43eff3de9
>>>> >>
>>>> >> MD5 commons-vfs-distribution-2.1-bin.zip
>>>> b512a45c63d824eef826f174fd7a9245
>>>> >> SHA1 commons-vfs-distribution-2.1-bin.zip
>>>> >> 886cb5a430da58b3a68e2abf297b6f735d3ffaf0
>>>> >> MD5 commons-vfs-distribution-2.1-src.zip
>>>> 29645a0ad091c15b2cf76b619c33069f
>>>> >> SHA1 commons-vfs-distribution-2.1-src.zip
>>>> >> 5824cf4d802865b5e93ff62c90affa58df6c4384
>>>> >>
>>>> >> Signed with 4677D66C from
>>>> >> https://dist.apache.org/repos/dist/release/commons/KEYS
>>>> >>
>>>> >> SVN tag is available at
>>>> >>
>>>> https://svn.apache.org/repos/asf/commons/proper/vfs/tags/commons-vfs2-project-2.1-rc2/
>>>> >> r1743451
>>>> >>
>>>> >> Staged Maven website:
>>>> >> http://home.apache.org/~elserj/commons/commons-vfs-2.1/
>>>> >>
>>>> >> All reports are available in the provided staged Maven site (see
>>>> "Project
>>>> >> Reports" at the root-level as well as under each sub-module).
>>>> JIRA-generated
>>>> >> release notes are available in the dist.a.o "Artifacts" repository. Unit
>>>> >> tests pass and the RC was built util JDK6.
>>>> >>
>>>> >> (For Sebb) A direct Clirr link
>>>> >>
>>>> http://home.apache.org/~elserj/commons/commons-vfs-2.1/commons-vfs2/clirr-report.html
>>>> >>
>>>> >> Changes since rc1:
>>>> >>
>>>> >> * Fixed more compatibility concerns against 2.0 (thanks, Greg)
>>>> >> * Improved release notes (thanks, Sebb)
>>>> >>
>>>> >> This vote will be open for 72-hours, 2016/05/14 0400 UTC.
>>>> >>
>>>> >> [ ] +1 Release these artifacts as version 2.1
>>>> >> [ ] 0 OK, but...
>>>> >> [ ] -1 I oppose these artifacts as version 2.1 because..
>>>> >>
>>>> >> - Josh
>>>> >>
>>>> >> ---------------------------------------------------------------------
>>>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> >> For additional commands, e-mail: dev-help@commons.apache.org
>>>> >>
>>>> >>
>>>> >
>>>> > ---------------------------------------------------------------------
>>>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> > For additional commands, e-mail: dev-help@commons.apache.org
>>>> >
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>> --
>> Stian Soiland-Reyes
>> Apache Taverna (incubating), Apache Commons RDF (incubating)
>> http://orcid.org/0000-0001-9842-9718
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] NOTICE required for Jackrabbit's JcrUtils? (was: [VOTE]
Apache Commons VFS 2.1 rc2)
Posted by sebb <se...@gmail.com>.
On 16 May 2016 at 08:51, Stian Soiland-Reyes <st...@apache.org> wrote:
> In Jackrabbit's source code I find JcrUtils added in 2009:
>
> https://github.com/apache/jackrabbit/commit/0882a5cc1ed4ce1cf9d3c6b3a592f97c5772ce25
>
> but Jackrabbit graduated from the incubator in 2006:
>
> http://incubator.apache.org/projects/jackrabbit.html
>
>
> So presumably the software from Day Software was added before that?
Yes.
> Which to me says this is a pure Apache contribution which is only
> covered by the regular "This product includes software developed at
> ASF" line.
That depends on which source files were used.
Were they ones which came from Day originally?
Or new ones?
> I'll ask on dev@jackrabbit to be sure.
>
>
> Here's a suggested NOTICE line, in case we still need it:
>
> ------------------------------
> commons-vfs2-project/core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java
> Adapted from Apache Jackrabbit 2.4.0:
>
> Based on source code originally developed by
> Day Software (http://www.day.com/).
> ------------------------------
The NOTICE file is only for *required* attributions.
We should not add any text 'just in case'
In any case, I'm not sure that the JackRabbit NOTICE file needs to
contain the "Based on ..." paragraph.
Is that para actually *required*?
>
> We don't need to replicate the ASF self-attribution - see
> http://www.apache.org/dev/licensing-howto.html#bundle-asf-product
>
>
> ~
>
> On 13 May 2016 at 17:48, Gary Gregory <ga...@gmail.com> wrote:
>> On Fri, May 13, 2016 at 3:13 AM, sebb <se...@gmail.com> wrote:
>>
>>> On 13 May 2016 at 01:24, Sean Busbey <bu...@apache.org> wrote:
>>> > -1 (non-binding)
>>> >
>>> > bad:
>>> >
>>> > * LICENSE/NOTICE file is missing a bundled third party reference[1]
>>> >
>>> > maybe fine:
>>> >
>>> > * source artifacts mostly match source tag[2]
>>> > * build / test from source works[3]
>>> >
>>> > fine:
>>> > * verified signatures and checksums[4]
>>> >
>>> > [1]:
>>> >
>>> >
>>> core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java
>>> >
>>> > says it is copied from Apache Jackrabbit 2.4.0, which has a NOTICE.txt
>>> file.
>>>
>>> i.e.
>>>
>>> http://svn.apache.org/repos/asf/jackrabbit/tags/2.4.0/NOTICE.txt
>>>
>>> > there is no mention of this in the source repo NOTICE (I would presume
>>> the
>>> > related test jar would also be wrong).
>>>
>>> Whether that is needed or not depends on whether the specific file was
>>> part of the original source code from Day.
>>>
>>> The file was added as a part of fixing VFS-392
>>>
>>> @Gary: can you advise which source files you used to create JcrUtils?
>>>
>>
>> No idea, that was a long time ago. All I can say for sure is that I was
>> looking at the Jackrabbit 1.6.5 or earlier sources.
>>
>> Gary
>>
>>>
>>> > [2]:
>>> >
>>> > The source tag contains an additional module 'sandbox' that is not in
>>> the source artifact.
>>> >
>>> > I am not sure if this is intentional, but it looks like it is.
>>> >
>>> > [3]:
>>> >
>>> > Related to [2], if you run `mvn verify` things are fine, but if you use
>>> the sandbox profile,
>>> > via `mvn -Pinclude-sandbox verify`, things fall over because the above
>>> mentioned module
>>> > is missing.
>>> >
>>> > [4]:
>>> >
>>> > everything properly checks out, but the format of the md5 file was
>>> different for the artifacts in
>>> > dist.apache compared to repository.apache.
>>> >
>>> > On 2016-05-11 20:29, Josh Elser <el...@apache.org> wrote:
>>> >> All,
>>> >>
>>> >> Please consider the following for Apache Commons VFS2 version 2.1 (rc2).
>>> >>
>>> >> Maven repository:
>>> >>
>>> https://repository.apache.org/content/repositories/orgapachecommons-1166
>>> >> Artifacts: https://dist.apache.org/repos/dist/dev/commons/vfs/ r13608
>>> >>
>>> >> MD5 commons-vfs-distribution-2.1-bin.tar.gz
>>> >> 8cc35a3169e1faee727c5af94c7dd904
>>> >> SHA1 commons-vfs-distribution-2.1-bin.tar.gz
>>> >> 72b7557c4e8b1789b8aa0a9c1e0cb2c9daecec30
>>> >> MD5 commons-vfs-distribution-2.1-src.tar.gz
>>> >> a182ac642874e85fbc7d1086f7663482
>>> >> SHA1 commons-vfs-distribution-2.1-src.tar.gz
>>> >> e42ac2053deb314277213e43f6f1d6b43eff3de9
>>> >>
>>> >> MD5 commons-vfs-distribution-2.1-bin.zip
>>> b512a45c63d824eef826f174fd7a9245
>>> >> SHA1 commons-vfs-distribution-2.1-bin.zip
>>> >> 886cb5a430da58b3a68e2abf297b6f735d3ffaf0
>>> >> MD5 commons-vfs-distribution-2.1-src.zip
>>> 29645a0ad091c15b2cf76b619c33069f
>>> >> SHA1 commons-vfs-distribution-2.1-src.zip
>>> >> 5824cf4d802865b5e93ff62c90affa58df6c4384
>>> >>
>>> >> Signed with 4677D66C from
>>> >> https://dist.apache.org/repos/dist/release/commons/KEYS
>>> >>
>>> >> SVN tag is available at
>>> >>
>>> https://svn.apache.org/repos/asf/commons/proper/vfs/tags/commons-vfs2-project-2.1-rc2/
>>> >> r1743451
>>> >>
>>> >> Staged Maven website:
>>> >> http://home.apache.org/~elserj/commons/commons-vfs-2.1/
>>> >>
>>> >> All reports are available in the provided staged Maven site (see
>>> "Project
>>> >> Reports" at the root-level as well as under each sub-module).
>>> JIRA-generated
>>> >> release notes are available in the dist.a.o "Artifacts" repository. Unit
>>> >> tests pass and the RC was built util JDK6.
>>> >>
>>> >> (For Sebb) A direct Clirr link
>>> >>
>>> http://home.apache.org/~elserj/commons/commons-vfs-2.1/commons-vfs2/clirr-report.html
>>> >>
>>> >> Changes since rc1:
>>> >>
>>> >> * Fixed more compatibility concerns against 2.0 (thanks, Greg)
>>> >> * Improved release notes (thanks, Sebb)
>>> >>
>>> >> This vote will be open for 72-hours, 2016/05/14 0400 UTC.
>>> >>
>>> >> [ ] +1 Release these artifacts as version 2.1
>>> >> [ ] 0 OK, but...
>>> >> [ ] -1 I oppose these artifacts as version 2.1 because..
>>> >>
>>> >> - Josh
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> >> For additional commands, e-mail: dev-help@commons.apache.org
>>> >>
>>> >>
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> > For additional commands, e-mail: dev-help@commons.apache.org
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons RDF (incubating)
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org