You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Anders Wallgren (JIRA)" <ji...@apache.org> on 2007/01/24 00:40:49 UTC

[jira] Created: (HTTPCORE-28) DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()

DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()
----------------------------------------------------------------------------------------------

                 Key: HTTPCORE-28
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-28
             Project: HttpComponents Core
          Issue Type: Bug
    Affects Versions: 4.0-alpha4
            Reporter: Anders Wallgren
             Fix For: 4.0-alpha4


DefaultConnectingIOReactor.connect() shouldn't call SocketChannel.register() while the Selector.select() is being called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Assigned: (HTTPCORE-28) DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski reassigned HTTPCORE-28:
-----------------------------------------

    Assignee: Oleg Kalnichevski

> DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-28
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-28
>             Project: HttpComponents Core
>          Issue Type: Bug
>    Affects Versions: 4.0-alpha4
>            Reporter: Anders Wallgren
>         Assigned To: Oleg Kalnichevski
>             Fix For: 4.0-alpha4
>
>         Attachments: DefaultConnectingIOReactor.patch
>
>
> DefaultConnectingIOReactor.connect() shouldn't call SocketChannel.register() while the Selector.select() is being called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCORE-28) DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()

Posted by "Anders Wallgren (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anders Wallgren updated HTTPCORE-28:
------------------------------------

    Attachment: DefaultConnectingIOReactor.patch

A quick patch to move the register calls into the same thread as the select.  It's quick-n-dirty based on the current contents of SVN as 2007-01-23.  Should be OK as long as select() after a wakeup() always returns immediately (I think).


> DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-28
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-28
>             Project: HttpComponents Core
>          Issue Type: Bug
>    Affects Versions: 4.0-alpha4
>            Reporter: Anders Wallgren
>             Fix For: 4.0-alpha4
>
>         Attachments: DefaultConnectingIOReactor.patch
>
>
> DefaultConnectingIOReactor.connect() shouldn't call SocketChannel.register() while the Selector.select() is being called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCORE-28) DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()

Posted by "Anders Wallgren (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCORE-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466862 ] 

Anders Wallgren commented on HTTPCORE-28:
-----------------------------------------

NB: the patch just rethrows exceptions, which probably isn't the right behavior...

> DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-28
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-28
>             Project: HttpComponents Core
>          Issue Type: Bug
>    Affects Versions: 4.0-alpha3
>            Reporter: Anders Wallgren
>         Assigned To: Oleg Kalnichevski
>            Priority: Critical
>             Fix For: 4.0-alpha4
>
>         Attachments: DefaultConnectingIOReactor.patch
>
>
> DefaultConnectingIOReactor.connect() shouldn't call SocketChannel.register() while the Selector.select() is being called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCORE-28) DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCORE-28:
--------------------------------------

             Priority: Critical  (was: Major)
    Affects Version/s:     (was: 4.0-alpha4)
                       4.0-alpha3

> DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-28
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-28
>             Project: HttpComponents Core
>          Issue Type: Bug
>    Affects Versions: 4.0-alpha3
>            Reporter: Anders Wallgren
>         Assigned To: Oleg Kalnichevski
>            Priority: Critical
>             Fix For: 4.0-alpha4
>
>         Attachments: DefaultConnectingIOReactor.patch
>
>
> DefaultConnectingIOReactor.connect() shouldn't call SocketChannel.register() while the Selector.select() is being called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Resolved: (HTTPCORE-28) DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCORE-28.
---------------------------------------

    Resolution: Fixed

I believe I have fixed the bug in the SVN trunk. Please review and re-open the bug if the problem persists

Oleg 

> DefaultConnectingIOReactor needs to queue new channels and call register() outside of select()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-28
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-28
>             Project: HttpComponents Core
>          Issue Type: Bug
>    Affects Versions: 4.0-alpha3
>            Reporter: Anders Wallgren
>         Assigned To: Oleg Kalnichevski
>            Priority: Critical
>             Fix For: 4.0-alpha4
>
>         Attachments: DefaultConnectingIOReactor.patch
>
>
> DefaultConnectingIOReactor.connect() shouldn't call SocketChannel.register() while the Selector.select() is being called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org