You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/07/12 16:04:41 UTC

[GitHub] sohami commented on a change in pull request #1376: DRILL-6592: Unnest record batch size is called too frequently

sohami commented on a change in pull request #1376: DRILL-6592: Unnest record batch size is called too frequently
URL: https://github.com/apache/drill/pull/1376#discussion_r202090727
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
 ##########
 @@ -216,7 +225,7 @@ public IterOutcome innerNext() {
         boolean isNewSchema = schemaChanged();
 
 Review comment:
   I think `isNewSchema` flag can be deprecated and replaced by `hasNewSchema`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services