[jira] [Commented] (DELTASPIKE-1185) Allow customization (name, description) of JMX managed methods' parameters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DELTASPIKE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385908#comment-15385908 ] 

ASF GitHub Bot commented on DELTASPIKE-1185:
--------------------------------------------

GitHub user kalgon opened a pull request:

    https://github.com/apache/deltaspike/pull/59

    DELTASPIKE-1185 Allow customization (name, description) of JMX managed...

    Hi,
    
    Here is a first try at implementing the customization (name + description) of JMX operations' parameters.
    
    I didn't know if it was better to make a new `@JmxParameter` annotation or reuse the existing `@JmxManaged` (which would have needed a new `name` attribute).
    
    I opted for the first solution but I can change it if needed. In the 2nd solution, adding a new `name` attribute to `@JmxManaged` could also allow to override the operation name.
    
    Regards,
    
    Xavier

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kalgon/deltaspike DELTASPIKE-1185

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/deltaspike/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
    
----
commit 0ab7e7043e0464e1ff66df8ed1f6a5ce9a021326
Author: Xavier Dury <ka...@hotmail.com>
Date:   2016-07-20T13:49:27Z

    DELTASPIKE-1185 Allow customization (name, description) of JMX managed
    methods' parameters

----


> Allow customization (name, description) of JMX managed methods' parameters
> --------------------------------------------------------------------------
>
>                 Key: DELTASPIKE-1185
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1185
>             Project: DeltaSpike
>          Issue Type: Wish
>          Components: Core
>    Affects Versions: 1.7.0
>            Reporter: Xavier Dury
>            Priority: Trivial
>
> Currently, it is not possible to name or give a description to parameters of {{@JmxManaged}} methods as {{DynamicMBeanWrapper}} uses the simple {{MBeanOperationInfo}} constructor which gives generic names to parameters like p0, p1, p2...
> It would be nice if we could annotate parameters with something like {{@JmxParameter(name = ..., description = ...)}} or - if using java 8 - use the parameter name which is available via reflection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)