[GitHub] [drill] vvysotskyi commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317130089
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
 ##########
 @@ -364,8 +365,8 @@ private TransferPair getFlattenFieldTransferPair(FieldReference reference) {
     final ValueVector flattenField = incoming.getValueAccessorById(vectorClass, fieldId.getFieldIds()).getValueVector();
 
     TransferPair tp = null;
-    if (flattenField instanceof RepeatedMapVector) {
-      tp = ((RepeatedMapVector)flattenField).getTransferPairToSingleMap(reference.getAsNamePart().getName(), oContext.getAllocator());
+    if (flattenField instanceof AbstractRepeatedMapVector) {
 
 Review comment:
   Does it mean that we will be able to produce flattening for DictVector?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services