You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/04/13 14:22:38 UTC

[PR] fix(sdk): inline iobuf into iggy_binary_protocol [iggy]

hubcio opened a new pull request, #3110:
URL: https://github.com/apache/iggy/pull/3110

   0.8.0 rc1 passed both PPMC and IPMC votes, then cargo publish
   revealed the iobuf crate could not reach crates.io: the name
   "iobuf" is already owned by an unrelated v5.8.1 crate, so adding
   a version field would have turned any downstream `cargo add
   iggy_common` into a supply-chain hazard resolving the foreign
   crate transitively.
   
   Publishing the workspace copy under a new name (iggy_iobuf) was
   rejected because it would commit the project to SemVer stability
   on ~485 LoC of refcounted unsafe code with zero tests, zero docs,
   and a latent refcount-underflow UAF masked by debug_assert!.
   
   Move core/iobuf/src/lib.rs verbatim into
   core/binary_protocol/src/consensus/iobuf.rs, delete the standalone
   crate, and update every consumer to import through
   iggy_binary_protocol::consensus::iobuf. The implementation is
   byte-for-byte unchanged; the existing lint debt is suppressed at
   the module declaration and tracked for a 0.9.x cleanup pass.
   
   Also close the SemVer leak:
   iobuf types were reachable through iggy_common's public API via
   FrozenBatchHeader and a `pub use send_messages2::*` wildcard
   re-export. Demote FrozenBatchHeader to pub(crate), drop the
   wildcard (no external consumers relied on it), and seal
   FragmentedBacking so downstream crates cannot implement it and
   pull Frozen<MESSAGE_ALIGN> into their own signatures.
   
   The publish chain drops from 5 crates to 4:
   iggy_binary_protocol -> iggy_common -> iggy -> iggy-cli.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sdk): inline iobuf into iggy_binary_protocol [iggy]

Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex merged PR #3110:
URL: https://github.com/apache/iggy/pull/3110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sdk): inline iobuf into iggy_binary_protocol [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3110:
URL: https://github.com/apache/iggy/pull/3110#issuecomment-4237166544

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3110?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 70.08%. Comparing base ([`44eea40`](https://app.codecov.io/gh/apache/iggy/commit/44eea40972c345885b6ddfedfe81efedd146171f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69adceb`](https://app.codecov.io/gh/apache/iggy/commit/69adceb1e229a7f6cac5de2b9b67337ad67fc5a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3110      +/-   ##
   ============================================
   - Coverage     72.75%   70.08%   -2.68%     
     Complexity      943      943              
   ============================================
     Files          1117     1054      -63     
     Lines         96342    91533    -4809     
     Branches      73540    73452      -88     
   ============================================
   - Hits          70096    64150    -5946     
   - Misses        23696    24934    +1238     
   + Partials       2550     2449     -101     
   ```
   
   | [Components](https://app.codecov.io/gh/apache/iggy/pull/3110/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.52% <ø> (-0.01%)` | :arrow_down: |
   | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.30% <ø> (ø)` | |
   | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.40% <ø> (ø)` | |
   | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.43% <ø> (ø)` | |
   | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.29% <ø> (-4.15%)` | :arrow_down: |
   | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `10.00% <ø> (-28.97%)` | :arrow_down: |
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3110?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [core/binary\_protocol/src/consensus/message.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fconsensus%2Fmessage.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2NvbnNlbnN1cy9tZXNzYWdlLnJz) | `49.45% <ø> (ø)` | |
   | [core/common/src/types/send\_messages2.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fsend_messages2.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL3NlbmRfbWVzc2FnZXMyLnJz) | `44.32% <ø> (ø)` | |
   | [core/consensus/src/plane\_helpers.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fplane_helpers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL3BsYW5lX2hlbHBlcnMucnM=) | `86.36% <ø> (ø)` | |
   | [core/journal/src/prepare\_journal.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fjournal%2Fsrc%2Fprepare_journal.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9qb3VybmFsL3NyYy9wcmVwYXJlX2pvdXJuYWwucnM=) | `82.77% <ø> (ø)` | |
   | [core/metadata/src/impls/recovery.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fimpls%2Frecovery.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvaW1wbHMvcmVjb3ZlcnkucnM=) | `70.63% <ø> (ø)` | |
   | [core/partitions/src/iggy\_partitions.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fpartitions%2Fsrc%2Figgy_partitions.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9wYXJ0aXRpb25zL3NyYy9pZ2d5X3BhcnRpdGlvbnMucnM=) | `31.67% <ø> (ø)` | |
   | [core/partitions/src/journal.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fpartitions%2Fsrc%2Fjournal.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9wYXJ0aXRpb25zL3NyYy9qb3VybmFsLnJz) | `18.43% <ø> (ø)` | |
   | [core/partitions/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fpartitions%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9wYXJ0aXRpb25zL3NyYy9saWIucnM=) | `0.00% <ø> (ø)` | |
   | [core/partitions/src/messages\_writer.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fpartitions%2Fsrc%2Fmessages_writer.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9wYXJ0aXRpb25zL3NyYy9tZXNzYWdlc193cml0ZXIucnM=) | `0.00% <ø> (ø)` | |
   | [core/partitions/src/types.rs](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree&filepath=core%2Fpartitions%2Fsrc%2Ftypes.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9wYXJ0aXRpb25zL3NyYy90eXBlcy5ycw==) | `8.86% <ø> (ø)` | |
   | ... and [3 more](https://app.codecov.io/gh/apache/iggy/pull/3110?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [123 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3110/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org