You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/11 19:08:14 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #3822: HDDS-7305. Fix Hadoop imports

adoroszlai opened a new pull request, #3822:
URL: https://github.com/apache/ozone/pull/3822

   ## What changes were proposed in this pull request?
   
    * Replace one import from Hadoop's shaded Guava.
    * Add direct dependencies for various Apache Commons libs instead of relying on getting them transitively via Hadoop.
   
   Different Hadoop versions may not depend on all these libraries (or shade different Guava version), so using transitive dependency explicitly (via import) risks breaking with some version of Hadoop.
   
   https://issues.apache.org/jira/browse/HDDS-7305
   
   ## How was this patch tested?
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/3228775529


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #3822: HDDS-7305. Fix Hadoop imports

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3822:
URL: https://github.com/apache/ozone/pull/3822#issuecomment-1275787230

   > How did you identify the pom file changes?
   
   Trial and error.  Added the exclude, then resolved build failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc merged pull request #3822: HDDS-7305. Fix Hadoop imports

Posted by GitBox <gi...@apache.org>.
captainzmc merged PR #3822:
URL: https://github.com/apache/ozone/pull/3822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #3822: HDDS-7305. Fix Hadoop imports

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3822:
URL: https://github.com/apache/ozone/pull/3822#issuecomment-1283859702

   Thanks @captainzmc for reviewing and merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc commented on pull request #3822: HDDS-7305. Fix Hadoop imports

Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #3822:
URL: https://github.com/apache/ozone/pull/3822#issuecomment-1283860214

   Thanks @adoroszlai, I will cherry-pick this to release branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #3822: HDDS-7305. Fix Hadoop imports

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3822:
URL: https://github.com/apache/ozone/pull/3822#issuecomment-1275640482

   How did you identify the pom file changes? I understand the import change, but not sure how the pom file updates were speced out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org