You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anjiahao1 (via GitHub)" <gi...@apache.org> on 2024/08/11 15:27:52 UTC
[PR] Coredump enhancement, optimized prompt statements [nuttx]
anjiahao1 opened a new pull request, #12889:
URL: https://github.com/apache/nuttx/pull/12889
## Summary
Coredump enhancement, optimized prompt statements
1. In some architectures, registers cannot be copied using memcpy. However, reading the register contents by uintptr is supported.
2. Optimized the message prompts after successfully or unsuccessfully using coredump.
## Impact
coredump
## Testing
vela & qemu wtih mpsan547 use coredump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coredump enhancement, optimized prompt statements [nuttx]
Posted by "anjiahao1 (via GitHub)" <gi...@apache.org>.
anjiahao1 commented on code in PR #12889:
URL: https://github.com/apache/nuttx/pull/12889#discussion_r1713108401
##########
binfmt/libelf/libelf_coredump.c:
##########
@@ -423,9 +423,34 @@ static void elf_emit_memory(FAR struct elf_dumpinfo_s *cinfo, int memsegs)
for (i = 0; i < memsegs; i++)
{
- elf_emit(cinfo, (FAR void *)cinfo->regions[i].start,
- cinfo->regions[i].end -
- cinfo->regions[i].start);
+ if (cinfo->regions[i].flags & PF_REGISTER)
Review Comment:
Some chips require 4-byte register access, but you don't want to lose the memcpy optimization when copying memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coredump enhancement, optimized prompt statements [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12889:
URL: https://github.com/apache/nuttx/pull/12889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coredump enhancement, optimized prompt statements [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12889:
URL: https://github.com/apache/nuttx/pull/12889#discussion_r1713098774
##########
binfmt/libelf/libelf_coredump.c:
##########
@@ -423,9 +423,34 @@ static void elf_emit_memory(FAR struct elf_dumpinfo_s *cinfo, int memsegs)
for (i = 0; i < memsegs; i++)
{
- elf_emit(cinfo, (FAR void *)cinfo->regions[i].start,
- cinfo->regions[i].end -
- cinfo->regions[i].start);
+ if (cinfo->regions[i].flags & PF_REGISTER)
Review Comment:
why not just copy unaligned data and emit aligned pointer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org