You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2014/10/17 23:19:31 UTC
Review Request 26891: Fix CBO to use indexes when GenericUDFBridge is
applied
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26891/
-----------------------------------------------------------
Review request for hive and Sergey Shelukhin.
Repository: hive-git
Description
-------
previous https://issues.apache.org/jira/browse/HIVE-8389 assumes that
we have predicate: ((UDFToDouble(key) > UDFToDouble(80)) and (UDFToDouble(key) < UDFToDouble(100))) for example.
This does not work for the case when we have predicate: ((UDFToDouble(key) > 80.0) and (UDFToDouble(key) < 100.0))
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 4987f7a
Diff: https://reviews.apache.org/r/26891/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 26891: Fix CBO to use indexes when
GenericUDFBridge is applied
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26891/#review57243
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java
<https://reviews.apache.org/r/26891/#comment97789>
this check is gone... I wonder if it would be valid if user did add some UDF to only one side? Maybe it should look at casts specifically
- Sergey Shelukhin
On Oct. 17, 2014, 9:19 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26891/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 9:19 p.m.)
>
>
> Review request for hive and Sergey Shelukhin.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> previous https://issues.apache.org/jira/browse/HIVE-8389 assumes that
> we have predicate: ((UDFToDouble(key) > UDFToDouble(80)) and (UDFToDouble(key) < UDFToDouble(100))) for example.
> This does not work for the case when we have predicate: ((UDFToDouble(key) > 80.0) and (UDFToDouble(key) < 100.0))
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 4987f7a
>
> Diff: https://reviews.apache.org/r/26891/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 26891: Fix CBO to use indexes when
GenericUDFBridge is applied
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26891/
-----------------------------------------------------------
(Updated Oct. 19, 2014, 5:58 p.m.)
Review request for hive and Sergey Shelukhin.
Repository: hive-git
Description
-------
previous https://issues.apache.org/jira/browse/HIVE-8389 assumes that
we have predicate: ((UDFToDouble(key) > UDFToDouble(80)) and (UDFToDouble(key) < UDFToDouble(100))) for example.
This does not work for the case when we have predicate: ((UDFToDouble(key) > 80.0) and (UDFToDouble(key) < 100.0))
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 4987f7a
Diff: https://reviews.apache.org/r/26891/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 26891: Fix CBO to use indexes when
GenericUDFBridge is applied
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26891/
-----------------------------------------------------------
(Updated Oct. 19, 2014, 5:40 p.m.)
Review request for hive and Sergey Shelukhin.
Changes
-------
address [~julianhyde]'s comments about "equals"
Repository: hive-git
Description
-------
previous https://issues.apache.org/jira/browse/HIVE-8389 assumes that
we have predicate: ((UDFToDouble(key) > UDFToDouble(80)) and (UDFToDouble(key) < UDFToDouble(100))) for example.
This does not work for the case when we have predicate: ((UDFToDouble(key) > 80.0) and (UDFToDouble(key) < 100.0))
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 4987f7a
Diff: https://reviews.apache.org/r/26891/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 26891: Fix CBO to use indexes when
GenericUDFBridge is applied
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26891/
-----------------------------------------------------------
(Updated Oct. 18, 2014, 6:42 a.m.)
Review request for hive and Sergey Shelukhin.
Changes
-------
leverage Ashutosh's constant folding code.
Test
-Dtest=TestCliDriver -Dqfile=alter_concatenate_indexed_table.q,alter_index.q,authorization_index.q,drop_index_removes_partition_dirs.q,index_auth.q,index_auto.q,index_auto_empty.q,index_auto_file_format.q,index_auto_mult_tables.q,index_auto_mult_tables_compact.q,index_auto_multiple.q,index_auto_partitioned.q,index_auto_self_join.q,index_auto_unused.q,index_auto_update.q,index_bitmap.q,index_bitmap1.q,index_bitmap2.q,index_bitmap3.q,index_bitmap_auto.q,index_bitmap_auto_partitioned.q,index_bitmap_compression.q,index_bitmap_rc.q,index_compact.q,index_compact_1.q,index_compact_2.q,index_compact_3.q,index_compact_binary_search.q,index_compression.q,index_creation.q,index_serde.q,index_stale.q,index_stale_partitioned.q,show_indexes_edge_cases.q,show_indexes_syntax.q,udf_index.q
and -Dtest=TestHBaseCliDriver -Dqfile=hbase_ppd_key_range.q,hbase_pushdown.q
Repository: hive-git
Description
-------
previous https://issues.apache.org/jira/browse/HIVE-8389 assumes that
we have predicate: ((UDFToDouble(key) > UDFToDouble(80)) and (UDFToDouble(key) < UDFToDouble(100))) for example.
This does not work for the case when we have predicate: ((UDFToDouble(key) > 80.0) and (UDFToDouble(key) < 100.0))
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 4987f7a
Diff: https://reviews.apache.org/r/26891/diff/
Testing
-------
Thanks,
pengcheng xiong