You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Pat Ferrel (JIRA)" <ji...@apache.org> on 2015/05/19 18:01:59 UTC

[jira] [Comment Edited] (MAHOUT-1708) Replace Preconditions with asserts for Spark code

    [ https://issues.apache.org/jira/browse/MAHOUT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550671#comment-14550671 ] 

Pat Ferrel edited comment on MAHOUT-1708 at 5/19/15 4:01 PM:
-------------------------------------------------------------

AbstractIterator and Map uses from guava are also problems here (Andrew's comments on IM)

[~andrew.musselman] can you create a PR branch so others can help with this?


was (Author: pferrel):
[~andrew.musselman] can you create a PR branch so others can help with this?

> Replace Preconditions with asserts for Spark code
> -------------------------------------------------
>
>                 Key: MAHOUT-1708
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1708
>             Project: Mahout
>          Issue Type: Bug
>          Components: Hdfs, Math
>    Affects Versions: 0.10.0
>         Environment: Spark
>            Reporter: Pat Ferrel
>            Assignee: Andrew Musselman
>             Fix For: 0.10.1
>
>
> all use of guava has been removed from the code used with Spark except the use of Preconditions. These are pretty easy to replace. 
> 1) remove guava from mahout-math, mahout-hdfs, poms and the spark dependency-reduced assembly.
> 2) you will now get compile errors for math and hdfs so remove the imports and replace and Preconditions with asserts.
> Not sure how many errors in replacing these will be caught with unit tests so be careful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)