[jira] [Commented] (CALCITE-3115) Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

["TANG Wen-hui (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857566#comment-16857566 ] 

TANG Wen-hui commented on CALCITE-3115:
---------------------------------------

Once JdbcAggregateRule(JDBC.test, RelFactories.LOGICAL_BUILDER) was added to ruleset, JdbcAggregateRule(JDBC.test2, RelFactories.LOGICAL_BUILDER) cannot be added to same planner's ruleset, since they have same description. And the hashCode() of RelOptRule are:

public int hashCode() {
 // Conventionally, hashCode() and equals() should use the same
 // criteria, whereas here we only look at the description. This is
 // okay, because the planner requires all rule instances to have
 // distinct descriptions.
 return description.hashCode();
}

(JDBC.test and JDBC.test2 are JdbcConvention.) 

So I have changed the description of JdbcRules. 

> Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.
> ------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3115
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3115
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: TANG Wen-hui
>            Assignee: TANG Wen-hui
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When we use Calcite via JDBC to run a sql which involves two difference jdbc schema:
> {code:java}
> select * from (select "a",max("b") as max_b, sum("c") as sum_c from "test"."temp" where "d" > 10 or "b" <> 'hello' group by "a", "e", "f" having "a" > 100 and max("b") < 20 limit 10) t  union select "a", "b","c" from "test2"."temp2" group by "a","b","c" 
> {code}
> the sql get a plan like that:
> {code:java}
> EnumerableUnion(all=[false])
>   JdbcToEnumerableConverter
>     JdbcProject(a=[$0], MAX_B=[$3], SUM_C=[$4])
>       JdbcSort(fetch=[10])
>         JdbcFilter(condition=[<(CAST($3):BIGINT, 20)])
>           JdbcAggregate(group=[{0, 4, 5}], MAX_B=[MAX($1)], SUM_C=[SUM($2)])
>             JdbcFilter(condition=[AND(OR(>($3, 10), <>($1, 'hello')), >($0, 100))])
>               JdbcTableScan(table=[[test, temp]])
>   EnumerableAggregate(group=[{0, 1, 2}])
>     JdbcToEnumerableConverter
>       JdbcTableScan(table=[[test2, temp2]])
> {code}
> And the EnumerableAggregate for table test2.temp2 cannot be converted to JdbcAggregate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)