You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2017/02/20 12:58:19 UTC
Review Request 56854: Wizard 'Assign Master ' step is showing
inconsistent Select view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56854/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-20082
https://issues.apache.org/jira/browse/AMBARI-20082
Repository: ambari
Description
-------
In Wizard > Assign Mater step, the select host menu is not consistent with the whole style guide. Should make it looks like a normal dropdown.
As investigated, it is impossible to customize the "Option" menu, so would consider replacing that with dropdown button and dropdown menu.
Diffs
-----
ambari-web/app/styles/application.less aa8f075
ambari-web/app/styles/wizard.less 579b21b
ambari-web/app/templates/common/assign_master_components.hbs a0a4990
ambari-web/app/templates/common/form/dropdown.hbs PRE-CREATION
ambari-web/app/views.js 6972d2a
ambari-web/app/views/common/assign_master_components_view.js 4646cf0
ambari-web/app/views/common/form/dropdown.js PRE-CREATION
Diff: https://reviews.apache.org/r/56854/diff/
Testing
-------
20376 passing (26s)
153 pending
Thanks,
Aleksandr Kovalenko
Re: Review Request 56854: Wizard 'Assign Master ' step is showing
inconsistent Select view
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56854/#review166089
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On \u041b\u044e\u0442. 20, 2017, 12:58 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56854/
> -----------------------------------------------------------
>
> (Updated \u041b\u044e\u0442. 20, 2017, 12:58 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari and Andriy Babiichuk.
>
>
> Bugs: AMBARI-20082
> https://issues.apache.org/jira/browse/AMBARI-20082
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Wizard > Assign Mater step, the select host menu is not consistent with the whole style guide. Should make it looks like a normal dropdown.
> As investigated, it is impossible to customize the "Option" menu, so would consider replacing that with dropdown button and dropdown menu.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less aa8f075
> ambari-web/app/styles/wizard.less 579b21b
> ambari-web/app/templates/common/assign_master_components.hbs a0a4990
> ambari-web/app/templates/common/form/dropdown.hbs PRE-CREATION
> ambari-web/app/views.js 6972d2a
> ambari-web/app/views/common/assign_master_components_view.js 4646cf0
> ambari-web/app/views/common/form/dropdown.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56854/diff/
>
>
> Testing
> -------
>
> 20376 passing (26s)
> 153 pending
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>