You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/14 17:55:56 UTC
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1613: Provide Actions class for Spark2 and Spark3
aokolnychyi commented on a change in pull request #1613:
URL: https://github.com/apache/iceberg/pull/1613#discussion_r504866663
##########
File path: spark/src/main/java/org/apache/iceberg/actions/CommonActions.java
##########
@@ -22,24 +22,16 @@
import org.apache.iceberg.Table;
import org.apache.spark.sql.SparkSession;
-public class Actions {
+public abstract class CommonActions {
Review comment:
I think we use `Base` quite a bit in other places. Would it make sense to call it `BaseActions`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org