[jira] [Commented] (OPENJPA-2731) Problems with Boolean Representation with Postgres

["Mark Struberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682576#comment-16682576 ] 

Mark Struberg commented on OPENJPA-2731:
----------------------------------------

Jody, I think this did only hit openjpa-2.2.x, right?

Because in 3.0.x and 2.4.x the PostgresDictionary doesn't have any {{setBoolean}} method.
Probably the original BooleanRepresentation patch did not get fully merged back to 2.2.x?
Can we close this ticket as resolved in 2.2.3 or so?

> Problems with Boolean Representation with Postgres
> --------------------------------------------------
>
>                 Key: OPENJPA-2731
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2731
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.2.2
>            Reporter: Jody Grassel
>            Assignee: Jody Grassel
>            Priority: Major
>              Labels: easyfix
>             Fix For: 2.2.3
>
>         Attachments: patch_2.2.x.txt
>
>
> OPENJPA-2558 addressed, in general, boolean representations on the database (native Boolean column types, as an int(0,1), as a string, as a char, etc), but had coverage gaps with respect to the supported platforms.  Postgres is one of those platforms.  Its dictionary class still overrode setBoolean(), but did not equally override getBoolean() which introduced a conflict.
> I'm proposing an update which removes the setBoolean() method from the Postgres dbdictionary, as well as adding the ability for a database platform to declare a default boolean representation type (preserving the INT10 default, but setting Postgres' to BooleanRepresentation in order to match what the schemagenerator for postgres creates).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)