You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/07/15 20:16:03 UTC
[GitHub] [commons-codec] marcwrobel opened a new pull request, #139: (chore) Fix minor typos
marcwrobel opened a new pull request, #139:
URL: https://github.com/apache/commons-codec/pull/139
Fix various minor typos in :
- project documentations,
- javadoc and comments,
- method attribute names,
- test method names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] kinow commented on a diff in pull request #139: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #139:
URL: https://github.com/apache/commons-codec/pull/139#discussion_r922519903
##########
src/main/java/org/apache/commons/codec/binary/Base32.java:
##########
@@ -124,11 +124,6 @@ public class Base32 extends BaseNCodec {
// The private member fields below are used with the new streaming approach, which requires
// some state be preserved between calls of encode() and decode().
- /**
- * Place holder for the bytes we're dealing with for our based logic.
- * Bitwise operations store and extract the encoding or decoding from this variable.
- */
Review Comment:
Note to self: check out in git history if there was a variable below this comment before, or if this comment was intended for a block of variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] kinow merged pull request #139: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
kinow merged PR #139:
URL: https://github.com/apache/commons-codec/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] kinow commented on pull request #139: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #139:
URL: https://github.com/apache/commons-codec/pull/139#issuecomment-1185980298
Merged, thanks @marcwrobel !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] kinow commented on a diff in pull request #139: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #139:
URL: https://github.com/apache/commons-codec/pull/139#discussion_r922540511
##########
src/main/java/org/apache/commons/codec/binary/Base32.java:
##########
@@ -124,11 +124,6 @@ public class Base32 extends BaseNCodec {
// The private member fields below are used with the new streaming approach, which requires
// some state be preserved between calls of encode() and decode().
- /**
- * Place holder for the bytes we're dealing with for our based logic.
- * Bitwise operations store and extract the encoding or decoding from this variable.
- */
Review Comment:
This comment was for `bitWorkArea` — https://github.com/apache/commons-codec/commit/d6f305d2efd7560634217a25f3bbee59299844dd
That field was removed in CODEC-96, so safe to remove this comment now :detective: — https://github.com/apache/commons-codec/commit/3f41cf1609fae7c8848beb0655bcf67132c7a277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] codecov-commenter commented on pull request #139: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #139:
URL: https://github.com/apache/commons-codec/pull/139#issuecomment-1185948047
# [Codecov](https://codecov.io/gh/apache/commons-codec/pull/139?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#139](https://codecov.io/gh/apache/commons-codec/pull/139?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ca75a4) into [master](https://codecov.io/gh/apache/commons-codec/commit/11f9498f44e2b6f4f463f2af67a2b81cb86151c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (11f9498) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #139 +/- ##
=========================================
Coverage 92.17% 92.17%
Complexity 1745 1745
=========================================
Files 67 67
Lines 4652 4652
Branches 746 746
=========================================
Hits 4288 4288
Misses 249 249
Partials 115 115
```
| [Impacted Files](https://codecov.io/gh/apache/commons-codec/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/commons/codec/EncoderException.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvRW5jb2RlckV4Y2VwdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...n/java/org/apache/commons/codec/binary/Base16.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0Jhc2UxNi5qYXZh) | `98.52% <ø> (ø)` | |
| [...n/java/org/apache/commons/codec/binary/Base32.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0Jhc2UzMi5qYXZh) | `97.19% <ø> (ø)` | |
| [...apache/commons/codec/binary/Base32InputStream.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0Jhc2UzMklucHV0U3RyZWFtLmphdmE=) | `100.00% <ø> (ø)` | |
| [...n/java/org/apache/commons/codec/binary/Base64.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0Jhc2U2NC5qYXZh) | `94.87% <ø> (ø)` | |
| [...apache/commons/codec/binary/Base64InputStream.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0Jhc2U2NElucHV0U3RyZWFtLmphdmE=) | `100.00% <ø> (ø)` | |
| [...pache/commons/codec/binary/Base64OutputStream.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0Jhc2U2NE91dHB1dFN0cmVhbS5qYXZh) | `100.00% <ø> (ø)` | |
| [...va/org/apache/commons/codec/binary/BaseNCodec.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0Jhc2VOQ29kZWMuamF2YQ==) | `96.19% <ø> (ø)` | |
| [...apache/commons/codec/binary/CharSequenceUtils.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvYmluYXJ5L0NoYXJTZXF1ZW5jZVV0aWxzLmphdmE=) | `83.33% <ø> (ø)` | |
| [...n/java/org/apache/commons/codec/digest/Blake3.java](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29kZWMvZGlnZXN0L0JsYWtlMy5qYXZh) | `95.67% <ø> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/commons-codec/pull/139/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-codec/pull/139?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/commons-codec/pull/139?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [11f9498...2ca75a4](https://codecov.io/gh/apache/commons-codec/pull/139?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org