You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ki...@apache.org on 2021/04/28 11:45:15 UTC
[commons-text] branch master updated (ef7d124 -> 7bbea10)
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git.
from ef7d124 Merge branch 'pr-225'
new d2ace4f [TEXT-205] Set void return method
new 9ea65ab [TEXT-205] Changelog
new 7bbea10 Merge branch 'pr-230'
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/text/ExtendedMessageFormat.java | 9 +++++----
2 files changed, 6 insertions(+), 4 deletions(-)
[commons-text] 03/03: Merge branch 'pr-230'
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git
commit 7bbea10702126a18ad01207d4763f73ec9ed07c3
Merge: ef7d124 9ea65ab
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Wed Apr 28 23:44:29 2021 +1200
Merge branch 'pr-230'
This closes #230
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/text/ExtendedMessageFormat.java | 9 +++++----
2 files changed, 6 insertions(+), 4 deletions(-)
[commons-text] 01/03: [TEXT-205] Set void return method
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git
commit d2ace4fb47a7d686e18eaed0ae829bb6faa6479d
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Tue Apr 27 06:44:42 2021 +0200
[TEXT-205] Set void return method
---
src/main/java/org/apache/commons/text/ExtendedMessageFormat.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java b/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java
index de45715..f24efb7 100644
--- a/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java
+++ b/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java
@@ -516,9 +516,8 @@ public class ExtendedMessageFormat extends MessageFormat {
* @param pattern pattern to parse
* @param pos current parse position
* @param appendTo optional StringBuilder to append
- * @return {@code appendTo}
*/
- private StringBuilder appendQuotedString(final String pattern, final ParsePosition pos,
+ private void appendQuotedString(final String pattern, final ParsePosition pos,
final StringBuilder appendTo) {
assert pattern.toCharArray()[pos.getIndex()] == QUOTE
: "Quoted string must start with quote character";
@@ -535,8 +534,10 @@ public class ExtendedMessageFormat extends MessageFormat {
switch (c[pos.getIndex()]) {
case QUOTE:
next(pos);
- return appendTo == null ? null : appendTo.append(c, start,
- pos.getIndex() - start);
+ if (appendTo != null) {
+ appendTo.append(c, start, pos.getIndex() - start);
+ }
+ return;
default:
next(pos);
}
[commons-text] 02/03: [TEXT-205] Changelog
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git
commit 9ea65ab1ca4af7e5ed163b0074655412757da67f
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Wed Apr 28 23:43:39 2021 +1200
[TEXT-205] Changelog
---
src/changes/changes.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4c78e19..c4b0cde 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -84,6 +84,7 @@ The <action> type attribute can be add,update,fix,remove.
<action issue="TEXT-204" type="update" dev="kinow" due-to="Arturo Bernal">Use static class inner class in tests.</action>
<action issue="TEXT-201" type="update" dev="kinow" due-to="Arturo Bernal">Simplify assertion.</action>
<action issue="TEXT-202" type="update" dev="kinow" due-to="Arturo Bernal">Extract duplicate code.</action>
+ <action issue="TEXT-205" type="update" dev="kinow" due-to="Arturo Bernal">Set void return method.</action>
</release>
<release version="1.9" date="2020-07-21" description="Release 1.9. Requires Java 8.">
<action issue="TEXT-166" type="fix" dev="kinow" due-to="Mikko Maunu">Removed non-existing parameter from Javadocs and spelled out parameters in throws.</action>