[GitHub] [shardingsphere] MingxingLAI opened a new issue #10497: The name of the Collection should be plural in ResponsePacketBuilder

[GitBox <gi...@apache.org>]

MingxingLAI opened a new issue #10497:
URL: https://github.com/apache/shardingsphere/issues/10497


   Please look at the following code block:
   
   ```Java
      public static Collection<DatabasePacket<?>> buildQueryResponsePackets(final QueryResponseHeader queryResponseHeader) {
           Collection<DatabasePacket<?>> result = new LinkedList<>();
           int sequenceId = 0;
           List<QueryHeader> queryHeader = queryResponseHeader.getQueryHeaders();
           result.add(new MySQLFieldCountPacket(++sequenceId, queryHeader.size()));
           for (QueryHeader each : queryHeader) {
               result.add(new MySQLColumnDefinition41Packet(++sequenceId, getColumnFieldDetailFlag(each), each.getSchema(), each.getTable(), each.getTable(),
                       each.getColumnLabel(), each.getColumnName(), each.getColumnLength(), MySQLBinaryColumnType.valueOfJDBCType(each.getColumnType()), each.getDecimals(), false));
           }
           result.add(new MySQLEofPacket(++sequenceId));
           return result;
       }
   ```
   
   
   The variable name `queryHeader` puzzles me，I think `queryHeaders` is more suitable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #10497: The name of the Collection should be plural in ResponsePacketBuilder

[GitBox <gi...@apache.org>]

tristaZero closed issue #10497:
URL: https://github.com/apache/shardingsphere/issues/10497


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org