You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/06/13 12:33:43 UTC
[jira] [Commented] (BOOKKEEPER-203) improve ledger manager
interface to remove zookeeper dependency on metadata operations.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294328#comment-13294328 ]
Ivan Kelly commented on BOOKKEEPER-203:
---------------------------------------
Patch looks good. There's some small issues with it.
- Needs to be rebased on trunk
- MetaStoreException is not used. Is in wrong patch i guess?
- BookKeeper.java patch removed the throwing of NoSuchLedgerExistsException, which we added in BOOKKEEPER-273. Is this intentional?
- there are two overloads of getClass where only one is ever used. setClass is unused.
- LedgerManagerFactory#newLedgerManagerFactory breaks getLedgerManagerType(). if factoryClass is null and layout is null, it should check getLedgerManagerType before setting factoryClass to FlatLedgerManagerType or HierarchicalLedgerManagerType.
- This does introduce some incompatiblity. A 4.1.0 client will not work with an installation that has been initialised with the LedgerLayout code from this patch. This should be fine though, as LedgerLayout is only ever written on cluster initialization. However, I think we should change this to use protobufs so that any other changes like this are more BC friendly. Not in this patch though.
- You may as well you MultiLedgerManagerBaseTestCase for the places where you use MultiLedgerManagerTestCase and get rid of MultiLedgerManagerTestCase.
> improve ledger manager interface to remove zookeeper dependency on metadata operations.
> ---------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-203
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-203
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-203.diff, BOOKKEEPER-203.diff_v2, BOOKKEEPER-203.diff_v3, BOOKKEEPER-203.diff_v4
>
>
> we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira