[GitHub] [spark] beliefer commented on a diff in pull request #42629: [SPARK-44930][SQL] Deterministic ApplyFunctionExpression should be foldable

["beliefer (via GitHub)" <gi...@apache.org>]

beliefer commented on code in PR #42629:
URL: https://github.com/apache/spark/pull/42629#discussion_r1302851974


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala:
##########
@@ -425,3 +447,14 @@ case class SerializableBoxedInt(intVal: Int) {
 class NotSerializableBoxedInt(intVal: Int) {
   def addAsInt(other: Int): Int = intVal + other
 }
+
+case object CharLength extends ScalarFunction[Int] {

Review Comment:
   Could we reuse the `CharLength` defined at `JDBCV2Suite`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org