You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/23 08:15:59 UTC
[GitHub] [dubbo-go-pixiu] gongna-au opened a new pull request, #528: Optimizing Metric Implementation
gongna-au opened a new pull request, #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528
…ect performance
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #433
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ma642 commented on a diff in pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
ma642 commented on code in PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#discussion_r1045229084
##########
pixiu/pkg/prometheus/prometheus.go:
##########
@@ -343,6 +349,10 @@ func (p *Prometheus) HandlerFunc() ContextHandlerFunc {
if err2 == nil {
p.resSz.WithLabelValues(statusStr, method, url).Observe(float64(resSz))
}
+ var mutex sync.RWMutex
+ mutex.Lock()
+ p.Ppg.counter = p.Ppg.counter + 1
+ mutex.Unlock()
p.SetPushGateway()
Review Comment:
这里会造成并发问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1324726373
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1324691208
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1345743375
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1325862383
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1330212900
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1325869606
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1324778316
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#528](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (970b7aa) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/93a5cc61e2818309904605e8b586a62ee0baf37d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93a5cc6) will **increase** coverage by `0.00%`.
> The diff coverage is `16.66%`.
```diff
@@ Coverage Diff @@
## develop #528 +/- ##
========================================
Coverage 54.68% 54.68%
========================================
Files 666 666
Lines 77865 77865
========================================
+ Hits 42578 42582 +4
+ Misses 31648 31642 -6
- Partials 3639 3641 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pixiu/pkg/filter/prometheus/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl4aXUvcGtnL2ZpbHRlci9wcm9tZXRoZXVzL21ldHJpYy5nbw==) | `58.33% <16.66%> (-5.56%)` | :arrow_down: |
| [pkg/config/mesh/kubemesh/watcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9tZXNoL2t1YmVtZXNoL3dhdGNoZXIuZ28=) | `59.01% <0.00%> (-11.48%)` | :arrow_down: |
| [pkg/envoy/admin.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Vudm95L2FkbWluLmdv) | `50.00% <0.00%> (-9.68%)` | :arrow_down: |
| [pilot/pkg/config/memory/monitor.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL2NvbmZpZy9tZW1vcnkvbW9uaXRvci5nbw==) | `71.79% <0.00%> (-7.70%)` | :arrow_down: |
| [pilot/pkg/xds/monitoring.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3hkcy9tb25pdG9yaW5nLmdv) | `78.57% <0.00%> (-2.86%)` | :arrow_down: |
| [pkg/envoy/instance.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Vudm95L2luc3RhbmNlLmdv) | `76.27% <0.00%> (-1.70%)` | :arrow_down: |
| [pilot/pkg/xds/adstest.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3hkcy9hZHN0ZXN0Lmdv) | `66.66% <0.00%> (-1.52%)` | :arrow_down: |
| [pkg/wasm/cache.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dhc20vY2FjaGUuZ28=) | `88.48% <0.00%> (-1.05%)` | :arrow_down: |
| [pilot/pkg/xds/discovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3hkcy9kaXNjb3ZlcnkuZ28=) | `84.93% <0.00%> (-0.97%)` | :arrow_down: |
| [pilot/pkg/model/jwks\_resolver.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL21vZGVsL2p3a3NfcmVzb2x2ZXIuZ28=) | `78.29% <0.00%> (-0.78%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/528/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1345718335
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1325877094
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] gongna-au closed pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
gongna-au closed pull request #528: Optimizing Metric Implementation
URL: https://github.com/apache/dubbo-go-pixiu/pull/528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ma642 commented on a diff in pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
ma642 commented on code in PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#discussion_r1032920081
##########
pkg/metrics/prometheus/prometheus.go:
##########
@@ -343,6 +344,7 @@ func (p *Prometheus) HandlerFunc() ContextHandlerFunc {
if err2 == nil {
p.resSz.WithLabelValues(statusStr, method, url).Observe(float64(resSz))
}
+ p.Ppg.counter = p.Ppg.counter + 1
Review Comment:
这个有并发问题，没有加锁.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1324758395
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1325939455
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#issuecomment-1330217005
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=528)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=528&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=528&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] baerwang commented on a diff in pull request #528: Optimizing Metric Implementation
Posted by GitBox <gi...@apache.org>.
baerwang commented on code in PR #528:
URL: https://github.com/apache/dubbo-go-pixiu/pull/528#discussion_r1034236406
##########
pkg/metrics/prometheus/prometheus.go:
##########
@@ -261,40 +263,41 @@ func (p *Prometheus) registerMetrics() {
}
}
-func (p *Prometheus) SetMetricPath(path string) {
- p.MetricsPath = path
-}
-
-func (p *Prometheus) SetPushGatewayUrl(pushGatewayURL, metricsURL string, pushInterval time.Duration) {
+func (p *Prometheus) SetPushGatewayUrl(pushGatewayURL, metricspath string) {
p.Ppg.PushGatewayURL = pushGatewayURL
- p.MetricsPath = metricsURL
- p.Ppg.PushInterval = pushInterval
- p.MetricsPath = metricsURL
-
+ p.MetricsPath = metricspath
}
-func (p *Prometheus) SetPushGateway() {
- p.startPushTicker()
+func (p *Prometheus) SetPushIntervalThreshold(isTurn bool, pushIntervalThreshold int) {
+ p.Ppg.CounterPush = isTurn
+ p.Ppg.PushIntervalThreshold = pushIntervalThreshold
}
func (p *Prometheus) SetPushGatewayJob(j string) {
p.Ppg.Job = j
}
-func (p *Prometheus) startPushTicker() {
- p.sendMetricsToPushGateway(p.getMetrics())
+func (p *Prometheus) startPushCounter() {
+ if p.Ppg.counter >= p.Ppg.PushIntervalThreshold {
+ go p.sendMetricsToPushGateway(p.getMetrics())
+ p.Ppg.counter = 0
+ }
}
-func (p *Prometheus) getMetrics() []byte {
+func (p *Prometheus) SetPushGateway() {
+ if p.Ppg.CounterPush {
+ p.startPushCounter()
+ }
+}
+func (p *Prometheus) getMetrics() []byte {
out := &bytes.Buffer{}
metricFamilies, _ := prometheus.DefaultGatherer.Gather()
Review Comment:
def new error field,use it
##########
pkg/metrics/prometheus/prometheus.go:
##########
@@ -19,7 +19,6 @@ package prometheus
Review Comment:
will file move pixiu/pkg/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org