You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/10 00:06:01 UTC
Review Request: FLAGS (3): Moved common/logging.hpp|cpp into
logging/logging.hpp|cpp, added 'flags' namespace,
and did some preliminary replacement of Configuration by adding
logging::Flags and master::Flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5856/
-----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/Makefile.am 11f6b4c
src/common/attributes.hpp b773f74
src/common/logging.hpp 1fe48bd
src/common/logging.cpp e174852
src/common/utils.hpp c8bdccf
src/configurator/configurator.hpp 8569645
src/exec/exec.cpp e663ee1
src/flags/flags.hpp PRE-CREATION
src/java/jni/convert.cpp 2fbc789
src/launcher/executor.cpp 4fadebf
src/local/local.cpp d35639f
src/local/main.cpp 4d59ab1
src/log/main.cpp d9c7f28
src/log/network.hpp b9fdb8c
src/logging/logging.hpp PRE-CREATION
src/logging/logging.cpp PRE-CREATION
src/master/flags.hpp PRE-CREATION
src/master/frameworks_manager.cpp c6ce31e
src/master/http.cpp 82784fb
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/master.cpp 44a5dc6
src/master/slaves_manager.hpp a572d83
src/master/slaves_manager.cpp 7813a69
src/sched/sched.cpp dc91154
src/slave/main.cpp c08a55d
src/state/leveldb.cpp a0ce822
src/state/state.hpp d8788ca
src/state/zookeeper.cpp c82b8a3
src/tests/flags_tests.cpp PRE-CREATION
src/tests/main.cpp 7cebe0e
Diff: https://reviews.apache.org/r/5856/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: FLAGS (3): Moved common/logging.hpp|cpp into
logging/logging.hpp|cpp, added 'flags' namespace,
and did some preliminary replacement of Configuration by adding
logging::Flags and master::Flags.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5856/#review9064
-----------------------------------------------------------
Ship it!
src/master/slaves_manager.hpp
<https://reviews.apache.org/r/5856/#comment19207>
nice to see these fall away
- John Sirois
On July 9, 2012, 10:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5856/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 10:06 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 11f6b4c
> src/common/attributes.hpp b773f74
> src/common/logging.hpp 1fe48bd
> src/common/logging.cpp e174852
> src/common/utils.hpp c8bdccf
> src/configurator/configurator.hpp 8569645
> src/exec/exec.cpp e663ee1
> src/flags/flags.hpp PRE-CREATION
> src/java/jni/convert.cpp 2fbc789
> src/launcher/executor.cpp 4fadebf
> src/local/local.cpp d35639f
> src/local/main.cpp 4d59ab1
> src/log/main.cpp d9c7f28
> src/log/network.hpp b9fdb8c
> src/logging/logging.hpp PRE-CREATION
> src/logging/logging.cpp PRE-CREATION
> src/master/flags.hpp PRE-CREATION
> src/master/frameworks_manager.cpp c6ce31e
> src/master/http.cpp 82784fb
> src/master/main.cpp bcbe35a
> src/master/master.hpp 886f79c
> src/master/master.cpp 44a5dc6
> src/master/slaves_manager.hpp a572d83
> src/master/slaves_manager.cpp 7813a69
> src/sched/sched.cpp dc91154
> src/slave/main.cpp c08a55d
> src/state/leveldb.cpp a0ce822
> src/state/state.hpp d8788ca
> src/state/zookeeper.cpp c82b8a3
> src/tests/flags_tests.cpp PRE-CREATION
> src/tests/main.cpp 7cebe0e
>
> Diff: https://reviews.apache.org/r/5856/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>