[GitHub] [spark] beliefer commented on a diff in pull request #42144: [SPARK-37377][SQL][FOLLOWUP] Fix the partitioned join of one side test case not match

["beliefer (via GitHub)" <gi...@apache.org>]

beliefer commented on code in PR #42144:
URL: https://github.com/apache/spark/pull/42144#discussion_r1273366903


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/KeyGroupedPartitioningSuite.scala:
##########
@@ -310,9 +310,8 @@ class KeyGroupedPartitioningSuite extends DistributionAndOrderingSuiteBase {
 
   test("partitioned join: only one side reports partitioning") {
     val customers_partitions = Array(bucket(4, "customer_id"))
-    val orders_partitions = Array(bucket(2, "customer_id"))
 
-    testWithCustomersAndOrders(customers_partitions, orders_partitions, 2)

Review Comment:
   It seems `testWithCustomersAndOrders(customers_partitions, orders_partitions, 2)` is OK too ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org