You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by yoshidakuy <gi...@git.apache.org> on 2016/01/08 09:10:35 UTC

[GitHub] spark pull request: [SPARK-1270８][UI] Sorting task error in Stag...

GitHub user yoshidakuy opened a pull request:

    https://github.com/apache/spark/pull/10663

    [SPARK-1270８][UI] Sorting task error in Stages Page when yarn mode.

    If sort column contains slash(e.g. "Executor ID / Host") when yarn mode,sort fail with following message.
    
    ![spark-12708](https://cloud.githubusercontent.com/assets/6679275/12193320/80814f8c-b62a-11e5-9914-7bf3907029df.png)
    
    
    Ｉt's similar to SPARK-4313 .

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yoshidakuy/spark SPARK-12708

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10663
    
----
commit fc45425bc80a039994e57d2d98c0a6f281427654
Author: root <root@r520t1.(none)>
Date:   2016-01-08T07:59:02Z

    [SPARK-12708][UI] Sorting task error in Stages Page when yarn mode

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by zsxwing <gi...@git.apache.org>.

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10663#discussion_r49760805
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala ---
    @@ -59,7 +61,8 @@ private[ui] class PoolTable(pools: Seq[Schedulable], parent: StagesTab) {
           case None => 0
         }
         val href = "%s/stages/pool?poolname=%s"
    -      .format(UIUtils.prependBaseUri(parent.basePath), p.name)
    +      .format(UIUtils.prependBaseUri(parent.basePath),
    +        URLEncoder.encode(p.name, "UTF-8"))
    --- End diff --
    
    This two lines can be fit into one line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/10663#issuecomment-169937595
  
    **[Test build #49013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49013/consoleFull)** for PR 10663 at commit [`fc45425`](https://github.com/apache/spark/commit/fc45425bc80a039994e57d2d98c0a6f281427654).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by sarutak <gi...@git.apache.org>.

Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10663#discussion_r49734793
  
    --- Diff: core/src/test/scala/org/apache/spark/ui/UIUtilsSuite.scala ---
    @@ -67,6 +67,20 @@ class UIUtilsSuite extends SparkFunSuite {
           s"\nRunning progress bar should round down\n\nExpected:\n$expected\nGenerated:\n$generated")
       }
     
    +  test("decodeURLParameter (SPARK-12708: Sorting task error in Stages Page when yarn mode.)") {
    +    val encoded1 = "%252F"
    +    val decoded1 = "/"
    +    val encoded2 = "%253Cdriver%253E"
    +    val decoded2 = "<driver>"
    +
    +    assert(decoded1.sameElements(decodeURLParameter(encoded1)))
    +    assert(decoded2.sameElements(decodeURLParameter(encoded2)))
    --- End diff --
    
    Why don't you just compare by `===` instead of `sameElements`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/10663#issuecomment-170018160
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49018/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/10663


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/10663#issuecomment-171780948
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/10663#issuecomment-171838535
  
    **[Test build #49414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49414/consoleFull)** for PR 10663 at commit [`384b990`](https://github.com/apache/spark/commit/384b990e237d6c0b311042301ed0252dc689569f).
     * This patch **fails from timeout after a configured wait of \`250m\`**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

Posted by zsxwing <gi...@git.apache.org>.

Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/10663#issuecomment-171782133
  
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org