You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/11 05:45:17 UTC

[GitHub] [arrow-datafusion] gandronchik commented on a diff in pull request #2177: udtf support

gandronchik commented on code in PR #2177:
URL: https://github.com/apache/arrow-datafusion/pull/2177#discussion_r846963525


##########
datafusion/core/src/datasource/listing/helpers.rs:
##########
@@ -99,6 +99,7 @@ impl ExpressionVisitor for ApplicabilityVisitor<'_> {
             Expr::ScalarUDF { fun, .. } => {
                 self.visit_volatility(fun.signature.volatility)
             }
+            Expr::TableUDF { fun, .. } => self.visit_volatility(fun.signature.volatility),

Review Comment:
   good point, however, it doesn't work in this case (because argument fun has different types for TableUDF and ScalarUDF)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org