[jira] [Commented] (AIRFLOW-5312) KubernetesPodOperator hangs when kubernetes API times out

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915756#comment-16915756 ] 

ASF GitHub Bot commented on AIRFLOW-5312:
-----------------------------------------

rolanddb commented on pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/5915
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issue:
     - https://issues.apache.org/jira/browse/AIRFLOW-5312
   
   ### Description
   
   - Adds `_request_timeout` on calls to Kubernetes API
   - Adds retry via `tenacity` so `pod_launcher` will not die
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KubernetesPodOperator hangs when kubernetes API times out
> ---------------------------------------------------------
>
>                 Key: AIRFLOW-5312
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5312
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib
>    Affects Versions: 1.10.4
>            Reporter: Roland de Boo
>            Assignee: Roland de Boo
>            Priority: Major
>
> The KubernetesPodOperator launches a Pod in Kubernetes and then continues to watch its state and stream its logs. This is done via the Kubernetes Api. Not all calls to the Kubernetes Api have a timeout defined, so the operator will wait indefinitely for a response and therefore get stuck.
> This is the same issue as https://issues.apache.org/jira/browse/AIRFLOW-5282 but now in the KubernetesPodOperator.
> The solution is to add a timeout on all Api calls, and handle the errors (catching them, adding tenacity retrying where appropriate).
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)