You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "stack (JIRA)" <ji...@apache.org> on 2007/06/21 21:14:25 UTC
[jira] Created: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
HClient fails to readjust when ROOT or META redeployed on new region server
---------------------------------------------------------------------------
Key: HADOOP-1516
URL: https://issues.apache.org/jira/browse/HADOOP-1516
Project: Hadoop
Issue Type: Bug
Components: contrib/hbase
Reporter: stack
Assignee: stack
Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514872 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12362401/patch.txt applied and successfully tested against trunk revision r558897.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/457/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/457/console
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
If it weren't for Hudson timing out tests, this patch would have worked a few revisions ago.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HADOOP-1516) HClient fails to readjust when
ROOT or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HADOOP-1516 started by Jim Kellerman.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: stack
> Assignee: Jim Kellerman
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman reassigned HADOOP-1516:
-------------------------------------
Assignee: Jim Kellerman (was: stack)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: stack
> Assignee: Jim Kellerman
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515071 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362458/patch.txt against trunk revision r559068.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/459/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/459/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
Ok, just changing the logging level should not have caused TestRegionServerAbort to succeed.
Going to upload a patch which just comments out the logging level change to see if it fails.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515102 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362464/patch.txt against trunk revision r559068.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/460/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/460/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515465 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362553/patch.txt against trunk revision r559623.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/465/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/465/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
Fixes an NPE and a couple of logic errors introduced in the previous patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515447 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362553/patch.txt against trunk revision r559068.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/464/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/464/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman reopened HADOOP-1516:
-----------------------------------
I'm still not comfortable with this patch. Going to replace some volatiles with atomics.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: stack
> Assignee: Jim Kellerman
> Attachments: patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
Increase logging for TestRegionServerAbort which only fails in Hudson and not my build environment.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Fix Version/s: 0.15.0
Affects Version/s: 0.15.0
Status: Patch Available (was: In Progress)
Works in my environment. See if Hudson agrees.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman resolved HADOOP-1516.
-----------------------------------
Resolution: Fixed
On further thought, I don't think extra work is needed on this. If a new issue arises, we'll create a new Jira issue for it.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
Reduce number of ipc timeouts in TestRegionServerAbort so test does not time out.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
Reduce number of HBase retries so tests do not time out
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
Runs in my environment. See if it will run in Hudson (which timed out two tests last time)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
Changes work in my environment. See if patch applies under Hudson
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
Make rootRegionLocation volatile so other threads can see the changes.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515624 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12362590/patch.txt applied and successfully tested against trunk revision r559623.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/468/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/468/console
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514911 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362405/patch.txt against trunk revision r558897.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/458/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/458/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
See if TestRegionServerAbort fails if logging is at default levels.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514854 ]
stack commented on HADOOP-1516:
-------------------------------
Patch looks good Jim.
In HClient#findServersForTable you have:
{code}
+ for (int tries = 0; tries < 2; tries++) {
{code}
in two places. Any reason for not using HClient#numRetries rather than a hard-coded '2'? (Same later in scanOneMetaRegion -- is there a copy paste error here because you are checking numRetries later, low in the loop -- search for '+ if(servers.size() == 0 && tries == numRetries - 1) {') Or if a reason, any reason for not making it configurable?
This is a little interesting:
+ volatile AtomicInteger numberOfMetaRegions;
Its interesting because the Atomic*s are described as extensions of volatile. Volatile is not needed here as assignment of the new AtomicInteger is done in the constructor so its initialization should be thread-safe.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
Resolve issues raised by Michael Stack
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: stack
> Assignee: Jim Kellerman
> Attachments: patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515603 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12362588/patch.txt applied and successfully tested against trunk revision r559623.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/467/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/467/console
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: Open)
More logging, closing open file handles, still works for me. See if we can get past test timeout in Hudson.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
The only change from the previous version of this patch is that the line that increases the logging level for TestRegionServerAbort is commented out
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515516 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362581/patch.txt against trunk revision r559623.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/466/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/466/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
Real close... still works in my environment. trying to understand the non-determinism of the Hudson environment
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514835 ]
Hadoop QA commented on HADOOP-1516:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12362392/patch.txt against trunk revision r558897.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/456/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/456/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Open (was: Patch Available)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
original patches incorrect.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: In Progress (was: Patch Available)
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Status: Patch Available (was: In Progress)
Addressed Michael's concerns and runs in my environment. Test again in Hudson to be sure.
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HADOOP-1516:
----------------------------------
Attachment: patch.txt
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1516) HClient fails to readjust when ROOT
or META redeployed on new region server
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514857 ]
Jim Kellerman commented on HADOOP-1516:
---------------------------------------
> In HClient#findServersForTable you have:
>
> {code}
> + for (int tries = 0; tries < 2; tries++) {
> {code}
>
> in two places. Any reason for not using HClient#numRetries rather than a hard-coded '2'?
> Or if a reason, any reason for not making it configurable?
I guess my original thinking on the subject was that some retries were different from others and that in order to recover more quickly, doing fewer retries in some cases would reduce the amount of time spent doing retries rather than going down the recovery path. But ultimately, I think you are right that the number of retries should be configurable to allow for more prolonged transition periods.
> (Same later in scanOneMetaRegion -- is there a copy paste error here because you are checking
> numRetries later, low in the loop -- search for '+if(servers.size() == 0 && tries == numRetries - 1) {')
No this is simply a cut and paste error. I thought I had gotten them all... I'll clean them up too.
> This is a little interesting:
>
> + volatile AtomicInteger numberOfMetaRegions;
> Its interesting because the Atomic*s are described as extensions of volatile. Volatile is not needed
> here as assignment of the new AtomicInteger is done in the constructor so its initialization should be
> thread-safe.
The was left over from a previous edit where the variable was a regular 'int' and not an AtomicInteger. I'll fix this too.
Thanks for the review. I've been staring at this code too long trying to figure out why it wasn't working before obviously and missed cleaning up some stuff I had intended to do (or thought I had done).
> HClient fails to readjust when ROOT or META redeployed on new region server
> ---------------------------------------------------------------------------
>
> Key: HADOOP-1516
> URL: https://issues.apache.org/jira/browse/HADOOP-1516
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.15.0
> Reporter: stack
> Assignee: Jim Kellerman
> Fix For: 0.15.0
>
> Attachments: patch.txt, patch.txt, patch.txt
>
>
> Trying to add assertions about state to the test of region server clean shutdown and aborts, I notice that subsequent to ROOT and META regions moving to fresh region server, any attempt by the client to get actual content from the new locations fails with ConnectException trying to fetch from the closed region server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.