You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyangting <gi...@git.apache.org> on 2017/07/20 09:24:04 UTC

[GitHub] spark pull request #18688: delete the superfluous ��� symbol

GitHub user wangyangting opened a pull request:

    https://github.com/apache/spark/pull/18688

    delete the superfluous ‘ symbol

    **'ByKey** --> **ByKey**
    and `'ByKey` operations  --> and `ByKey` operations
    
    ## How was this patch tested?
    before -->
    ![5x9 z l kssfjjb0a072 h](https://user-images.githubusercontent.com/26565020/28410296-ccc50d04-6d6f-11e7-8999-6ae8057de3aa.png)
    
    delete the superfluous ‘ symbol

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyangting/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18688
    
----
commit b22ebdf475292fdabba878a6f742fea448cf24f0
Author: 那伊抹微笑 <10...@qq.com>
Date:   2017-07-20T09:17:44Z

    delete superfluous ‘ symbol
    
    **'ByKey** --> **ByKey**
    and `'ByKey` operations  --> and `ByKey` operations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18688: delete the superfluous ��� symbol in rdd-programming-gui...

Posted by wangyangting <gi...@git.apache.org>.
Github user wangyangting commented on the issue:

    https://github.com/apache/spark/pull/18688
  
    you're right, but I think the use of "*ByKey" will be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18688: delete the superfluous ��� symbol in rdd-programming-gui...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18688
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18688: delete the superfluous ��� symbol in rdd-programming-gui...

Posted by wangyangting <gi...@git.apache.org>.
Github user wangyangting commented on the issue:

    https://github.com/apache/spark/pull/18688
  
    not yet, thanks 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18688: delete the superfluous ��� symbol in rdd-programm...

Posted by wangyangting <gi...@git.apache.org>.
Github user wangyangting closed the pull request at:

    https://github.com/apache/spark/pull/18688


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18688: delete the superfluous ��� symbol in rdd-programming-gui...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18688
  
    Actually, I think this is on purpose. It means all operations that end with "ByKey". It's analogous to how a quote is used to signify missing characters in "can't".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org