You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/11/15 23:49:20 UTC
[GitHub] [drill] vdiravka commented on a change in pull request #2377: DRILL-8034: Add support for java 17
vdiravka commented on a change in pull request #2377:
URL: https://github.com/apache/drill/pull/2377#discussion_r749763856
##########
File path: distribution/src/main/resources/drill-config.sh
##########
@@ -307,10 +307,11 @@ export DRILLBIT_OPTS="$DRILLBIT_OPTS -XX:ReservedCodeCacheSize=$DRILLBIT_CODE_CA
if [ $? -gt 0 ]; then
# Allow reflective access on Java 9+
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.base/java.lang=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens=java.base/java.util=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.base/sun.nio.ch=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.base/java.net=ALL-UNNAMED"
Review comment:
It is due to reflection limitations which comes starting from jdk16, right?
##########
File path: pom.xml
##########
@@ -3965,6 +3972,22 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>jdk15</id>
Review comment:
Is that for jdk15 only? If not possibly name it `<id>jdk9+</id>`
##########
File path: pom.xml
##########
@@ -1015,6 +1017,11 @@
<artifactId>asm</artifactId>
<version>${asm.version}</version>
</dependency>
+ <dependency>
Review comment:
I got explanation offline, but pls do share here the reason for adding this dependency for `maven-shade-plugin`
##########
File path: distribution/src/main/resources/drill-config.sh
##########
@@ -307,10 +307,11 @@ export DRILLBIT_OPTS="$DRILLBIT_OPTS -XX:ReservedCodeCacheSize=$DRILLBIT_CODE_CA
if [ $? -gt 0 ]; then
# Allow reflective access on Java 9+
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.base/java.lang=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens=java.base/java.util=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.base/sun.nio.ch=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.base/java.net=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.base/java.nio=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens java.security.jgss/sun.security.krb5=ALL-UNNAMED"
- export DRILLBIT_OPTS="$DRILLBIT_OPTS --illegal-access=permit"
Review comment:
Why did we have this config at all? :) It was for ASM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org