You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 20:34:31 UTC

[GitHub] [airflow] bluek1te commented on a diff in pull request #24737: Pass kwargs from vault hook to hvac client

bluek1te commented on code in PR #24737:
URL: https://github.com/apache/airflow/pull/24737#discussion_r922499293


##########
airflow/providers/hashicorp/hooks/vault.py:
##########
@@ -220,6 +224,7 @@ def __init__(
             radius_host=radius_host,
             radius_secret=self.connection.password,
             radius_port=radius_port,
+            **client_kwargs

Review Comment:
   I tried to capture the spirit of everything you said in the most recent amend. Will start working on verifying the precedence in the tests. Just to double check, the precedence should be:
   
   conn attributes > conn.extra keyword arguments > conn.extra.client_kwargs keyword arguments?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org