You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/22 14:42:25 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request #10682: Fix binary license check issues.
codelipenghui opened a new pull request #10682:
URL: https://github.com/apache/pulsar/pull/10682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #10682: Fix binary license check issues.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #10682:
URL: https://github.com/apache/pulsar/pull/10682#discussion_r637593358
##########
File path: pulsar-broker/pom.xml
##########
@@ -230,6 +230,11 @@
<artifactId>jersey-media-json-jackson</artifactId>
</dependency>
+ <dependency>
Review comment:
O it isn't.
The dependencyManagement section is like a default configuration but it deos not mean that dependencies declared up there take precedence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #10682: Fix binary license check issues and update jersey to 2.34 for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #10682:
URL: https://github.com/apache/pulsar/pull/10682#discussion_r638035342
##########
File path: distribution/server/src/assemble/LICENSE.bin.txt
##########
@@ -559,22 +559,20 @@ CDDL-1.1 -- licenses/LICENSE-CDDL-1.1.txt
- org.glassfish.hk2-osgi-resource-locator-1.0.3.jar
- org.glassfish.hk2.external-aopalliance-repackaged-2.6.1.jar
* Jersey
- - org.glassfish.jersey.containers-jersey-container-servlet-2.31.jar
- - org.glassfish.jersey.containers-jersey-container-servlet-core-2.31.jar
- - org.glassfish.jersey.core-jersey-client-2.31.jar
- - org.glassfish.jersey.core-jersey-common-2.31.jar
- - org.glassfish.jersey.core-jersey-server-2.31.jar
- - org.glassfish.jersey.ext-jersey-entity-filtering-2.31.jar
- - org.glassfish.jersey.media-jersey-media-jaxb-2.31.jar
- - org.glassfish.jersey.media-jersey-media-json-jackson-2.31.jar
- - org.glassfish.jersey.media-jersey-media-multipart-2.31.jar
- - org.glassfish.jersey.inject-jersey-hk2-2.31.jar
+ - org.glassfish.jersey.containers-jersey-container-servlet-2.34.jar
Review comment:
Updated the PR title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #10682: Fix binary license check issues and update jersey to 2.34 for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10682:
URL: https://github.com/apache/pulsar/pull/10682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #10682: Fix binary license check issues.
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #10682:
URL: https://github.com/apache/pulsar/pull/10682#discussion_r637561763
##########
File path: pulsar-client-admin/pom.xml
##########
@@ -56,6 +56,11 @@
<artifactId>jersey-media-json-jackson</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.activation</groupId>
+ <artifactId>jakarta.activation-api</artifactId>
+ </dependency>
Review comment:
Same as above, not sure why we need to add it here
##########
File path: distribution/server/src/assemble/LICENSE.bin.txt
##########
@@ -559,22 +559,20 @@ CDDL-1.1 -- licenses/LICENSE-CDDL-1.1.txt
- org.glassfish.hk2-osgi-resource-locator-1.0.3.jar
- org.glassfish.hk2.external-aopalliance-repackaged-2.6.1.jar
* Jersey
- - org.glassfish.jersey.containers-jersey-container-servlet-2.31.jar
- - org.glassfish.jersey.containers-jersey-container-servlet-core-2.31.jar
- - org.glassfish.jersey.core-jersey-client-2.31.jar
- - org.glassfish.jersey.core-jersey-common-2.31.jar
- - org.glassfish.jersey.core-jersey-server-2.31.jar
- - org.glassfish.jersey.ext-jersey-entity-filtering-2.31.jar
- - org.glassfish.jersey.media-jersey-media-jaxb-2.31.jar
- - org.glassfish.jersey.media-jersey-media-json-jackson-2.31.jar
- - org.glassfish.jersey.media-jersey-media-multipart-2.31.jar
- - org.glassfish.jersey.inject-jersey-hk2-2.31.jar
+ - org.glassfish.jersey.containers-jersey-container-servlet-2.34.jar
Review comment:
The log title should probably be changed into "Updating to Jersey 2.34"
##########
File path: pulsar-broker/pom.xml
##########
@@ -230,6 +230,11 @@
<artifactId>jersey-media-json-jackson</artifactId>
</dependency>
+ <dependency>
Review comment:
Why do we need to specify the dependency here? Pinning the version in the `dependencyManagement` section in top level pom should be enough, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #10682: Fix binary license check issues and update jersey to 2.34 for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #10682:
URL: https://github.com/apache/pulsar/pull/10682#discussion_r638039932
##########
File path: pulsar-client-admin/pom.xml
##########
@@ -56,6 +56,11 @@
<artifactId>jersey-media-json-jackson</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.activation</groupId>
+ <artifactId>jakarta.activation-api</artifactId>
+ </dependency>
Review comment:
I have excluded `jakarta.activation-api` in the root pom.xml of the `jersey-media-json-jackson` dependency, some components depends on `jersey-media-json-jackson` will also exclude the `jakarta.activation-api`, In this PR we just make sure Pulsar using the consistent version of `jakarta.activation-api`, not remove the dependency. So add `jakarta.activation-api` dependency for the components which depends on `jersey-media-json-jackson` before. I'm not sure if we can remove it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org